8000 fix(tests/core/partitioning): Fix tests of refactoring segmentation in partitioning by peri044 · Pull Request #1140 · pytorch/TensorRT · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix(tests/core/partitioning): Fix tests of refactoring segmentation in partitioning #1140

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8000
Jump to bottom
Merged
merged 14 commits into from
Jun 22, 2022
Merged

fix(tests/core/partitioning): Fix tests of refactoring segmentation in partitioning #1140

merged 14 commits into from
Jun 22, 2022

Conversation

peri044
Copy link
Collaborator
@peri044 peri044 commented Jun 22, 2022

Description

Extended #1067

Type of change

Please delete options that are not relevant and/or add your own.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Checklist:

  • My code follows the style guidelines of this project (You can use the linters)
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas and hacks
  • I have made corresponding changes to the documentation
  • I have added tests to verify my fix or my feature
  • New and existing unit tests pass locally with my changes
  • I have added the relevant labels to my PR in so that relevant reviewers are notified

bowang007 and others added 12 commits May 14, 2022 00:06
@bowang007
feat: refactoring segmentation in partitioning
da281ad 
Signed-off-by: Bo Wang <bowa@nvidia.com>
@bowang007
feat: cover more cases after refactoring segmentation
4f974fd 
Signed-off-by: Bo Wang <bowa@nvidia.com>
@bowang007
Merge remote-tracking branch 'origin' into refactor_segmentation
ccb826e
@bowang007
fix: fix the bug that tag Constant node as fallback node
22d91f5 
Signed-off-by: Bo Wang <bowa@nvidia.com>
@bowang007
fix: fix the bug that getDependencyNodes misses modifying nodes
1df7cbb 
Signed-off-by: Bo Wang <bowa@nvidia.com>
@bowang007
refactor: refactored the method of getting modifying nodes
0bd8a98 
Signed-off-by: Bo Wang <bowa@nvidia.com>
@bowang007
fix: nodes in If block should fallback it it dependes on any nonTenso…
8d9a8d4 
…r value that's produced in outer block

Signed-off-by: Bo Wang <bowa@nvidia.com>
@bowang007
tests: add test for inplace op in if block
da9b13c 
Signed-off-by: Bo Wang <bowa@nvidia.com>
@bowang007
Merge branch 'master' into refactor_segmentation
a557d14
@bowang007
chore: apply linting
e929b65 
Signed-off-by: Bo Wang <bowa@nvidia.com>
@peri044
fix: Fix tests and corner cases for resolving non tensor inputs in fa…
2af4a7c 
…llback

Signed-off-by: Dheeraj Peri <peri.dheeraj@gmail.com>
@peri044
chore: Fix linter issues
8e1e904 
Signed-off-by: Dheeraj Peri <peri.dheeraj@gmail.com>
@github-actions github-actions bot added component: core Issues re: The core compiler component: partitioning component: tests Issues re: Tests labels Jun 22, 2022
@peri044 peri044 mentioned this pull request Jun 22, 2022
Closed
6 tasks
github-actions[bot]
github-actions bot approved these changes Jun 22, 2022
View reviewed changes
Copy link
@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code conforms to C++ style guidelines

peri044 added 2 commits June 22, 2022 07:24
@peri044
chore: add misplaced no eval scripted loop fallback model
2b09d1d 
Signed-off-by: Dheeraj Peri <peri.dheeraj@gmail.com>
@peri044
chore: Minor fix in hub.py model name
85306d8 
Signed-off-by: Dheeraj Peri <peri.dheeraj@gmail.com>
github-actions[bot]
github-actions bot approved these changes Jun 22, 2022
View reviewed changes
Copy link
@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code conforms to C++ style guidelines

github-actions[bot]
github-actions bot approved these changes Jun 22, 2022
View reviewed changes
Copy link
@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code conforms to C++ style guidelines

@peri044 peri044 merged commit 983eabd into master Jun 22, 2022
@bowang007 bowang007 mentioned this pull request Jun 22, 2022
Closed
6 tasks
@bowang007 bowang007 mentioned this pull request Jul 6, 2022
Closed
This was referenced Jul 11, 2022
Closed
Closed
This was referenced Jul 11, 2022
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] approved these changes

@andi4191 andi4191 Awaiting requested review from andi4191

@bowang007 bowang007 Awaiting requested review from bowang007

@narendasan narendasan Awaiting requested review from narendasan

Assignees
No one assigned
Labels
cla signed component: core Issues re: The core compiler component: partitioning component: tests Issues re: Tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@peri044 @facebook-github-bot @bowang007
0