8000 fix: fix the bug of missing ops and edge cases for if block by bowang007 · Pull Request #1062 · pytorch/TensorRT · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix: fix the bug of missing ops and edge cases for if block #1062

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

fix: fix the bug of missing ops and edge cases for if block #1062

wants to merge 1 commit into from

Conversation

bowang007
Copy link
Collaborator
@bowang007 bowang007 commented May 12, 2022 •
edited
Loading

Signed-off-by: Bo Wang bowa@nvidia.com

Description

In partitioning, some OPs might be missing because these OPs are left in segmentation vectors. Fixed it.
For If block, there are some edge cases like

   = prim::If(%8)
    block0():
      %11 : Tensor[] = aten::append(%mod_list.2, %y.2) # modifying_op_error.py:13:12
      -> ()
    block1():
      -> ()

There was segmentation faults because Torch-TensorRT always thought the blocks in If node was not empty.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • My code follows the style guidelines of this project (You can use the linters)
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas and hacks
  • I have made corresponding changes to the documentation
  • I have added tests to verify my fix or my feature
  • New and existing unit tests pass locally with my changes

@bowang007
fix: fix the bug of missing ops and edge cases for if block
1e96f98 
Signed-off-by: Bo Wang <bowa@nvidia.com>
@bowang007 bowang007 requested a review from narendasan May 12, 2022 20:44
8000
@facebook-github-bot
Copy link
Contributor

Hi @bowang007!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@github-actions github-actions bot added component: core Issues re: The core compiler component: partitioning labels May 12, 2022
@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

@github-actions github-actions bot requested a review from peri044 May 23, 2022 16:59
narendasan
narendasan approved these changes Jun 22, 2022
View reviewed changes
Copy link
Collaborator
@narendasan narendasan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me, merge after @peri044 reviews

@bowang007
Copy link
Collaborator Author

looks like this has been merged together with #1140

@narendasan
Copy link
Collaborator

Can this be closed then?

@bowang007
Copy link
Collaborator Author

sure. Let me close it.

@bowang007 bowang007 closed this Jun 27, 2022
@bowang007 bowang007 deleted the bo branch June 27, 2022 23:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@narendasan narendasan narendasan approved these changes

@peri044 peri044 Awaiting requested review from peri044

Assignees
No one assigned
Labels
cla signed component: core Issues re: The core compiler component: partitioning
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bowang007 @facebook-github-bot @narendasan
0