feat (//cpp): Using atol and rtol based tolerance threshold for torchtrtc #1052
10000
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
There was a problem hiding this comment.
There are some changes that do not conform to C++ style guidelines:
diff --git a/workspace/cpp/bin/torchtrtc/main.cpp b/tmp/changes.txt
index e5a6c28..48d9eff 100644
--- a/workspace/cpp/bin/torchtrtc/main.cpp
+++ b/tmp/changes.txt
@@ -446,8 +446,8 @@ int main(int argc, char** argv) {
threshold_ss << "atol: " << atol_val << " rtol: " << rtol_val;
torchtrt::logging::log(
torchtrt::logging::Level::kWARNING,
- std::string("Maximum numerical deviation for output exceeds tolerance thresholds (") + threshold_ss.str() +
- std::string(")"));
+ std::string("Maximum numerical deviation for output exceeds tolerance thresholds (") +
+ threshold_ss.str() + std::string(")"));
}
}
} else {
ERROR: Some files do not conform to style guidelinesThere was a problem hiding this comment.
There are some changes that do not conform to C++ style guidelines:
diff --git a/workspace/cpp/bin/torchtrtc/main.cpp b/tmp/changes.txt
index e5a6c28..48d9eff 100644
--- a/workspace/cpp/bin/torchtrtc/main.cpp
+++ b/tmp/changes.txt
@@ -446,8 +446,8 @@ int main(int argc, char** argv) {
threshold_ss << "atol: " << atol_val << " rtol: " << rtol_val;
torchtrt::logging::log(
torchtrt::logging::Level::kWARNING,
- std::string("Maximum numerical deviation for output exceeds tolerance thresholds (") + threshold_ss.str() +
- std::string(")"));
+ std::string("Maximum numerical deviation for output exceeds tolerance thresholds (") +
+ threshold_ss.str() + std::string(")"));
}
}
} else {
ERROR: Some files do not conform to style guidelines|
/blossom-ci |
narendasan
reviewed
May 20, 2022
6 tasks
There was a problem hiding this comment.
There are some changes that do not conform to C++ style guidelines:
diff --git a/workspace/cpp/bin/torchtrtc/main.cpp b/tmp/changes.txt
index e5a6c28..48d9eff 100644
--- a/workspace/cpp/bin/torchtrtc/main.cpp
+++ b/tmp/changes.txt
@@ -446,8 +446,8 @@ int main(int argc, char** argv) {
threshold_ss << "atol: " << atol_val << " rtol: " << rtol_val;
torchtrt::logging::log(
torchtrt::logging::Level::kWARNING,
- std::string("Maximum numerical deviation for output exceeds tolerance thresholds (") + threshold_ss.str() +
- std::string(")"));
+ std::string("Maximum numerical deviation for output exceeds tolerance thresholds (") +
+ threshold_ss.str() + std::string(")"));
}
}
} else {
diff --git a/workspace/cpp/bin/torchtrtc/accuracy.cpp b/tmp/changes.txt
index 94592b0..4f99d17 100644
--- a/workspace/cpp/bin/torchtrtc/accuracy.cpp
+++ b/tmp/changes.txt
@@ -27,12 +27,9 @@ bool almost_equal(const at::Tensor& a, const at::Tensor& b, float atol, float rt
auto result = diff.abs().max().item<float>();
auto threshold = atol + (rtol * b.abs().max().item<float>());
+ torchtrt::logging::log(torchtrt::logging::Level::kDEBUG, std::string("Max Difference: ") + std::to_string(result));
torchtrt::logging::log(
- torchtrt::logging::Level::kDEBUG,
- std::string("Max Difference: ") + std::to_string(result));
- torchtrt::logging::log(
- torchtrt::logging::Level::kDEBUG,
- std::string("Acceptable Threshold: ") + std::to_string(threshold));
+ torchtrt::logging::Level::kDEBUG, std::string("Acceptable Threshold: ") + std::to_string(threshold));
return result <= threshold;
}
ERROR: Some files do not conform to style guidelines…ce test BREAKING CHANGE: The flag `--threshold` has been removed in favor of two flags `--atol` and `--rtol` which control the maximum absolute and relative tolerances for numberical deviation Signed-off-by: Naren Dasan <naren@narendasan.com> Signed-off-by: Naren Dasan <narens@nvidia.com> Signed-off-by: Anurag Dixit <a.dixit91@gmail.com> fix: Fix for rtol and atol tolerance limit in torchtrtc Signed-off-by: Anurag Dixit <a.dixit91@gmail.com> feat(//cpp)!: Using logger instead of std::cout Signed-off-by: Anurag Dixit <a.dixit91@gmail.com> chore!: Applying C++ lint Signed-off-by: Anurag Dixit <a.dixit91@gmail.com> chore!: Updated the tensor names as per review comments Signed-off-by: Anurag Dixit <a.dixit91@gmail.com>
3cbe2e2 to
664f117
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added rtol + atol tolerance check for torchtrtc. Similar to what we have for test benchmarks.
This PR is a replica of #1038
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Fixes # (issue)
#1030
Type of change
Please delete options that are not relevant and/or add your own.
Checklist: