feat(//tests): Update rtol and atol based tolerance for test cases #1055
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Anurag Dixit <a.dixit91@gmail.com>
|
Current threshold in test cases will act as absolute tolerance limit as intended. |
narendasan
reviewed
May 20, 2022
| LOG_GRAPH(a << std::endl << b << std::endl); | ||
| auto a_float = a.toType(at::kFloat); | ||
| auto b_float = b.toType(at::kFloat); | ||
|
|
||
| auto diff = a_float - b_float; | ||
| auto result = diff.abs().max().item<float>() - (atol + rtol * b.abs().max().item<float>()); | ||
| auto result = diff.abs().max().item<float>(); |
There was a problem hiding this comment.
This equation is still confusing (see #1052)
There was a problem hiding this comment.
Based on the discussion in 1052, is this resolved? Anurag mentioned we need this PR for DLFW release.
Signed-off-by: Anurag Dixit <a.dixit91@gmail.com>
There was a problem hiding this comment.
There are some changes that do not conform to C++ style guidelines:
diff --git a/workspace/tests/util/util.cpp b/tmp/changes.txt
index 6dc0d81..13d0d18 100644
--- a/workspace/tests/util/util.cpp
+++ b/tmp/changes.txt
@@ -18,7 +18,7 @@ bool almostEqual(const at::Tensor& computed_tensor, const at::Tensor& gt_tensor,
auto result = diff.abs().max().item<float>();
auto threshold = atol + (rtol * gt_tensor.abs().max().item<float>());
- LOG_GRAPH(std::string("Max Difference: ") + std::to_string(result) );
+ LOG_GRAPH(std::string("Max Difference: ") + std::to_string(result));
LOG_GRAPH(std::string("Acceptable Threshold: ") + std::to_string(threshold));
return result <= threshold;
ERROR: Some files do not conform to style guidelinesSigned-off-by: Anurag Dixit <a.dixit91@gmail.com>
peri044
approved these changes
Jun 13, 2022
| LOG_GRAPH(a << std::endl << b << std::endl); | ||
| auto a_float = a.toType(at::kFloat); | ||
| auto b_float = b.toType(at::kFloat); | ||
|
|
||
| auto diff = a_float - b_float; | ||
| auto result = diff.abs().max().item<float>() - (atol + rtol * b.abs().max().item<float>()); | ||
| auto result = diff.abs().max().item<float>(); |
There was a problem hiding this comment.
Based on the discussion in 1052, is this resolved? Anurag mentioned we need this PR for DLFW release.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Anurag Dixit a.dixit91@gmail.com
Description
Updating the tolerance metric using absolute and relative tolerance threshold.
This PR directly impacts the CI, DLFW workflow.
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Fixes # (issue)
#1054
Type of change
Please delete options that are not relevant and/or add your own.
Checklist: