fixed empty attribute bug in read_gtf when duplicate_attr=True #297
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Fixes #292 |
|
Latest commit fixes #291 by converting boolean columns into categoricals before assigning null values. I figured this would be the best strategy as we can't assume anything about the T/F value of a boolean variable, though I guess I'm not sure if "-1" or -1 is the best null value in this case. |
|
I will fix this tomorrow
…On Mon, 13 Mar 2023 at 18:21, Fairlie Reese ***@***.***> wrote:
Latest commit fixes #291
<#291> by converting
boolean columns into categoricals before assigning null values.
I figured this would be the best strategy as we can't assume anything
about the T/F value of a boolean variable.
—
Reply to this email directly, view it on GitHub
<#297 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AEHURUSSWHPIBPENCCXYI5LW35JSHANCNFSM6AAAAAAVYRTJ74>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
|
|
Sorry for the late reply. Thanks again. Have updated my contact info in github so I won't be this late ever again. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Empty attributes were accounted for in
read_gtf(duplicate_attr=False), but notread_gtf(duplicate_attr=True). This commit fixes the bug and moves the attribute parsing code to a separate function that bothduplicate_attrsoptions will call to prevent future inconsistent behavior.