8000 Remove a `test.only` in the lit-html tests. by bicknellr · Pull Request #1402 · lit/lit · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Remove a test.only in the lit-html tests. #1402

8000 New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 2, 2020
Merged

Remove a test.only in the lit-html tests. #1402

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3b2c446
Remove a `test.only` in the lit-html tests.
bicknellr Oct 31, 2020
0559f0f
Restore coercing null/undefined to empty string when concatenating
kevinpschaaf Nov 2, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/lit-html/src/lit-html.ts
CBDA
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1181,7 +1181,7 @@ export class AttributePart {
(this._value as Array<unknown>)[i] = v;
}
attributeValue +=
(typeof v === 'string' ? v : String(v)) + strings[i + 1];
(typeof v === 'string' ? v : String(v ?? '')) + strings[i + 1];
}
if (change && !noCommit) {
this._commitValue(remove ? nothing : attributeValue);
Expand Down
2 changes: 1 addition & 1 deletion packages/lit-html/src/test/lit-html_test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1731,7 +1731,7 @@ suite('lit-html', () => {
assert.strictEqual((container.firstElementChild as any).foo, 'A:1');
});

test.only('renders directives on EventParts', () => {
test('renders directives on EventParts', () => {
const handle = directive(
class extends Directive {
count = 0;
Expand Down
0