Remove a `test.only` in the lit-html tests. #1402

bicknellr · 2020-10-31T00:52:49Z

I haven't looked into the cause for the failures this exposes, but I believe they're all legitimately failing tests so we shouldn't (necessarily) wait to make them pass in this PR before merging.

github-actions · 2020-10-31T00:53:05Z

📊 Tachometer Benchmark Results

Summary

nop-update

lit-html-kitchen-sink: unsure 🔍 -2% - +8% (-0.77ms - +3.49ms)
^{this-change vs tip-of-tree}

render

lit-element-list: faster ✔ 0% - 4% (0.12ms - 4.85ms)
^{this-change vs tip-of-tree}
lit-html-kitchen-sink: unsure 🔍 -6% - +1% (-3.10ms - +0.77ms)
^{this-change vs tip-of-tree}
lit-html-repeat: unsure 🔍 -8% - +9% (-1.25ms - +1.45ms)
^{this-change vs tip-of-tree}
lit-html-template-heavy: unsure 🔍 -2% - +3% (-1.78ms - +2.70ms)
^{this-change vs tip-of-tree}
updating-element-list: unsure 🔍 -2% - +3% (-1.27ms - +2.34ms)
^{this-change vs tip-of-tree}

update

lit-element-list: unsure 🔍 -2% - +0% (-18.58ms - +4.81ms)
^{this-change vs tip-of-tree}
lit-html-kitchen-sink: unsure 🔍 -4% - +2% (-5.01ms - +3.10ms)
^{this-change vs tip-of-tree}
lit-html-repeat: unsure 🔍 -1% - +3% (-5.87ms - +13.02ms)
^{this-change vs tip-of-tree}
lit-html-template-heavy: unsure 🔍 -1% - +4% (-0.92ms - +7.38ms)
^{this-change vs tip-of-tree}
updating-element-list: unsure 🔍 -3% - +1% (-4.18ms - +1.99ms)
^{this-change vs tip-of-tree}

update-reflect

lit-element-list: unsure 🔍 -2% - +0% (-19.28ms - +1.87ms)
^{this-change vs tip-of-tree}
updating-element-list: unsure 🔍 -2% - +2% (-4.66ms - +4.17ms)
^{this-change vs tip-of-tree}

Results

lit-element-list

Browser: chrome-headless 86.0.4240.111
Sample size: 50
Built by: Benchmarks #467
Commit: cee6781

render

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	126.97ms - 130.42ms	-	faster ✔ 0% - 4% 0.12ms - 4.85ms	faster ✔ 22% - 25% 37.25ms - 42.18ms
tip-of-tree tip-of-tree	129.56ms - 132.79ms	slower ❌ 0% - 4% 0.12ms - 4.85ms	-	faster ✔ 21% - 23% 34.83ms - 39.62ms
previous-release previous-release	166.64ms - 170.17ms	slower ❌ 29% - 33% 37.25ms - 42.18ms	slower ❌ 26% - 30% 34.83ms - 39.62ms	-

update

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	1167.56ms - 1180.98ms	-	unsure 🔍 -2% - +0% -18.58ms - +4.81ms	faster ✔ 6% - 8% 77.24ms - 99.15ms
tip-of-tree tip-of-tree	1171.58ms - 1190.73ms	unsure 🔍 -0% - +2% -4.81ms - +18.58ms	-	faster ✔ 5% - 7% 68.40ms - 94.22ms
previous-release previous-release	1253.80ms - 1271.12ms	slower ❌ 7% - 8% 77.24ms - 99.15ms	slower ❌ 6% - 8% 68.40ms - 94.22ms	-

update-reflect

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	1234.70ms - 1249.56ms	-	unsure 🔍 -2% - +0% -19.28ms - +1.87ms	faster ✔ 5% - 6% 62.26ms - 83.92ms
tip-of-tree tip-of-tree	1243.30ms - 1258.36ms	unsure 🔍 -0% - +2% -1.87ms - +19.28ms	-	faster ✔ 4% - 6% 53.48ms - 75.29ms
previous-release previous-release	1307.33ms - 1323.10ms	slower ❌ 5% - 7% 62.26ms - 83.92ms	slower ❌ 4% - 6% 53.48ms - 75.29ms	-

lit-html-kitchen-sink

Browser: chrome-headless 86.0.4240.111
Sample size: 30
Built by: Benchmarks #467
Commit: cee6781

render

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	50.14ms - 52.56ms	-	unsure 🔍 -6% - +1% -3.10ms - +0.77ms	faster ✔ 18% - 23% 11.68ms - 14.98ms
tip-of-tree tip-of-tree	51.01ms - 54.02ms	unsure 🔍 -2% - +6% -0.77ms - +3.10ms	-	faster ✔ 16% - 22% 10.29ms - 14.05ms
previous-release previous-release	63.57ms - 65.80ms	slower ❌ 22% - 30% 11.68ms - 14.98ms	slower ❌ 19% - 27% 10.29ms - 14.05ms	-

update

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	123.80ms - 129.40ms	-	unsure 🔍 -4% - +2% -5.01ms - +3.10ms	unsure 🔍 -6% - +0% -7.21ms - +0.16ms
tip-of-tree tip-of-tree	124.62ms - 130.48ms	unsure 🔍 -2% - +4% -3.10ms - +5.01ms	-	unsure 🔍 -5% - +1% -6.36ms - +1.21ms
previous-release previous-release	127.73ms - 132.51ms	unsure 🔍 -0% - +6% -0.16ms - +7.21ms	unsure 🔍 -1% - +5% -1.21ms - +6.36ms	-

nop-update

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	43.13ms - 46.15ms	-	unsure 🔍 -2% - +8% -0.77ms - +3.49ms	unsure 🔍 -5% - +5% -2.26ms - +2.24ms
tip-of-tree tip-of-tree	41.78ms - 44.78ms	unsure 🔍 -8% - +2% -3.49ms - +0.77ms	-	unsure 🔍 -8% - +2% -3.61ms - +0.88ms
previous-release previous-release	42.98ms - 46.32ms	unsure 🔍 -5% - +5% -2.24ms - +2.26ms	unsure 🔍 -2% - +8% -0.88ms - +3.61ms	-

lit-html-repeat

Browser: chrome-headless 86.0.4240.111
Sample size: 30
Built by: Benchmarks #467
Commit: cee6781

render

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	15.07ms - 16.47ms	-	unsure 🔍 -8% - +9% -1.25ms - +1.45ms	faster ✔ 15% - 26% 2.93ms - 5.27ms
tip-of-tree tip-of-tree	14.51ms - 16.82ms	unsure 🔍 -9% - +8% -1.45ms - +1.25ms	-	faster ✔ 14% - 28% 2.72ms - 5.69ms
previous-release previous-release	18.93ms - 20.81ms	slower ❌ 18% - 34% 2.93ms - 5.27ms	slower ❌ 16% - 38% 2.72ms - 5.69ms	-

update

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	457.81ms - 472.12ms	-	unsure 🔍 -1% - +3% -5.87ms - +13.02ms	faster ✔ 30% - 33% 197.91ms - 221.84ms
tip-of-tree tip-of-tree	455.22ms - 467.56ms	unsure 🔍 -3% - +1% -13.02ms - +5.87ms	-	faster ✔ 30% - 33% 202.04ms - 224.85ms
previous-release previous-release	665.25ms - 684.43ms	slower ❌ 42% - 48% 197.91ms - 221.84ms	slower ❌ 43% - 49% 202.04ms - 224.85ms	-

lit-html-template-heavy

Browser: chrome-headless 86.0.4240.111
Sample size: 50
Built by: Benchmarks #467
Commit: cee6781

render

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	84.50ms - 88.00ms	-	unsure 🔍 -2% - +3% -1.78ms - +2.70ms	faster ✔ 12% - 17% 11.82ms - 16.98ms
tip-of-tree tip-of-tree	84.40ms - 87.18ms	unsure 🔍 -3% - +2% -2.70ms - +1.78ms	-	faster ✔ 13% - 17% 12.51ms - 17.21ms
previous-release previous-release	98.76ms - 102.54ms	slower ❌ 13% - 20% 11.82ms - 16.98ms	slower ❌ 14% - 20% 12.51ms - 17.21ms	-

update

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	175.77ms - 182.19ms	-	unsure 🔍 -1% - +4% -0.92ms - +7.38ms	faster ✔ 9% - 13% 18.95ms - 27.03ms
tip-of-tree tip-of-tree	173.13ms - 178.38ms	unsure 🔍 -4% - +0% -7.38ms - +0.92ms	-	faster ✔ 11% - 15% 22.63ms - 29.81ms
previous-release previous-release	199.52ms - 204.42ms	slower ❌ 10% - 15% 18.95ms - 27.03ms	slower ❌ 13% - 17% 22.63ms - 29.81ms	-

updating-element-list

Browser: chrome-headless 86.0.4240.111
Sample size: 50
Built by: Benchmarks #467
Commit: cee6781

render

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	68.04ms - 71.04ms	-	unsure 🔍 -2% - +3% -1.27ms - +2.34ms	unsure 🔍 -2% - +3% -1.51ms - +2.34ms
tip-of-tree tip-of-tree	68.00ms - 70.02ms	unsure 🔍 -3% - +2% -2.34ms - +1.27ms	-	unsure 🔍 -2% - +2% -1.69ms - +1.46ms
previous-release previous-release	67.92ms - 70.34ms	unsure 🔍 -3% - +2% -2.34ms - +1.51ms	unsure 🔍 -2% - +2% -1.46ms - +1.69ms	-

update

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	139.04ms - 143.24ms	-	unsure 🔍 -3% - +1% -4.18ms - +1.99ms	unsure 🔍 -4% - +1% -5.09ms - +1.07ms
tip-of-tree tip-of-tree	139.97ms - 144.50ms	unsure 🔍 -1% - +3% -1.99ms - +4.18ms	-	unsure 🔍 -3% - +2% -4.11ms - +2.28ms
previous-release previous-release	140.90ms - 145.41ms	unsure 🔍 -1% - +4% -1.07ms - +5.09ms	unsure 🔍 -2% - +3% -2.28ms - +4.11ms	-

update-reflect

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	232.77ms - 239.04ms	-	unsure 🔍 -2% - +2% -4.66ms - +4.17ms	unsure 🔍 -2% - +1% -5.48ms - +3.21ms
tip-of-tree tip-of-tree	233.04ms - 239.26ms	unsure 🔍 -2% - +2% -4.17ms - +4.66ms	-	unsure 🔍 -2% - +1% -5.22ms - +3.44ms
previous-release previous-release	234.03ms - 240.05ms	unsure 🔍 -1% - +2% -3.21ms - +5.48ms	unsure 🔍 -1% - +2% -3.44ms - +5.22ms	-

_{tachometer-reporter-action v2 for Benchmarks}

kevinpschaaf · 2020-11-02T18:09:30Z

Sorry about this; I'm working on fixes for this, I think it's better to fix them than to have master red for some amount of time.

kevinpschaaf · 2020-11-02T23:09:44Z

Ok, that was a simple merging mistake when reverting one of the code factorings late in the lit-ssr PR: 961e95c#diff-bead45bb43cda474d916704550a1b26322667aa42b814c48300b05be79b9a7ebR1181

Will push a fix to this branch.

kevinpschaaf

LGTM, with added fix

Remove a test.only in the lit-html tests.

3b2c446

bicknellr requested a review from kevinpschaaf October 31, 2020 00:52

Restore coercing null/undefined to empty string when concatenating

0559f0f

kevinpschaaf approved these changes Nov 2, 2020

View reviewed changes

bicknellr merged commit 564aac1 into lit-next Nov 2, 2020

bicknellr deleted the lit-next-test-only branch November 2, 2020 23:41

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Remove a `test.only` in the lit-html tests. #1402

Remove a `test.only` in the lit-html tests. #1402

📊 Tachometer Benchmark Results

Summary

nop-update

render

update

update-reflect

Results

render

update

update-reflect

render

update

nop-update

render

update

render

update

render

update

update-reflect

Remove a test.only in the lit-html tests. #1402

Remove a test.only in the lit-html tests. #1402

Conversation

📊 Tachometer Benchmark Results

Summary

nop-update

render

update

update-reflect

Results

render

update

update-reflect

render

update

nop-update

render

update

render

update

render

update

update-reflect

Choose a reason for hiding this comment

Remove a `test.only` in the lit-html tests. #1402

Remove a `test.only` in the lit-html tests. #1402