fix: remove quoting from rimraf commands #3434
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
f2f18d6 to
0b2f3f5
Compare
|
I've noticed this myself and had resorted to running |
9778d16 to
9a30633
Compare
82627ce to
185e694
Compare
185e694 to
4e4eb0e
Compare
tawera-manaena
approved these changes
May 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
running
npm run cleandoesn't work for me, the build/ and dist/ folders aren't removedModifications
when calling rimraf, we quote the args so that we get consistent glob behaviour. We need to add --glob option
Verification
checked the build/ and dist/ folders are removed