GPU: Validate that a texture format is valid for compute writes #13044
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Never mind about the API change, SDL_GPUTextureSupportsFormat is enough to support this. I'll make that change now. |
|
Turns out we don't need to check this in BeginComputePass at all because texture creation catches it now. Great! |
slouken
approved these changes
May 14, 2025
thatcosmonaut
added a commit
that referenced
this pull request
May 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only certain texture formats are valid for writes in a compute shader. This patch causes an assert if the texture binding is an invalid format.
It's probably worth also exposing this to the client with some kind of Supports query API call, but we can add that in a separate patch so we can cherry-pick this one back to 3.2.x.
Resolves #13043