add 8BitDo Controller #12964
Merged
add 8BitDo Controller #12964
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add SN30 Pro, SF30 Pro, Pro 2. Supported versions: Pro 2 v3.06 above SF30 Pro/SN30 Pro v2.05 above
slouken
reviewed
May 6, 2025
slouken
reviewed
May 6, 2025
slouken
reviewed
May 6, 2025
| device->product_id == USB_PRODUCT_8BITDO_SF30_Pro || device->product_id == USB_PRODUCT_8BITDO_Pro_2 || | ||
| device->product_id == USB_PRODUCT_8BITDO_Pro_2_BT) { | ||
| Uint8 data[USB_PACKET_LENGTH]; | ||
| int size = ReadFeatureReport(device->dev, 0x06, data, sizeof(data)); |
There was a problem hiding this comment.
Maybe make a define at the top of the file instead of hard-coding the number here?
slouken
reviewed
May 6, 2025
| @@ -236,7 +256,7 @@ static void HIDAPI_Driver8BitDo_HandleStatePacket(SDL_Joystick *joystick, SDL_Dr | |||
| { | |||
| Sint16 axis; | |||
| Uint64 timestamp = SDL_GetTicksNS(); | |||
| if (data[0] != 0x03 && data[0] != 0x01) { | |||
| if (data[0] != 0x03 && data[0] != 0x01 && data[0] != 0x04) { | |||
There was a problem hiding this comment.
Does the first byte vary depending on controller type? Maybe we should add the report ID as part of the SDL_Driver8BitDo_Context structure and validate that the packet matches the expected value for the current controller?
There was a problem hiding this comment.
It is not the type of controller, but the 0x04 report Id created for SN30 PRO/SF30 PRO/PRO 2 compatibility with previous versions of the report Id.
In the future, products that are compatible with SDL will be adapted using the 0x04 report Id.
slouken
reviewed
May 6, 2025
Co-authored-by: Sam Lantinga <slouken@libsdl.org>
Co-authored-by: Sam Lantinga <slouken@libsdl.org>
Co-authored-by: Sam Lantinga <slouken@libsdl.org>
|
Merged, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add SN30 Pro, SF30 Pro, Pro 2.
Supported versions:
Pro 2 v3.06 and above
SF30 Pro/SN30 Pro v2.05 and above