8000 [🎨] NT-1111 Adding 2 buttons in the new pledge footer by eoji · Pull Request #830 · kickstarter/android-oss · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

[🎨] NT-1111 Adding 2 buttons in the new pledge footer #830

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 9, 2020
Merged

[🎨] NT-1111 Adding 2 buttons in the new pledge footer #830

merged 1 commit into from
Apr 9, 2020

Conversation

eoji
Copy link
Contributor
@eoji eoji commented Apr 9, 2020 •
edited by jira bot
Loading

📲 What

Adding Continue and ProgressBar button in pledge screen footer.

🤔 Why

So I can use them in future PRs and not have conflicts in this file.

🛠 How

fragment_pledge_section_footer.xml

  • Added pledge_footer_continue_button button
  • Added fake pledge_footer_pledge_button_progress button

👀 See

Screenshots from XML previews in Android Studio

Continue Progress Pledge
Screen Shot 2020-04-09 at 11 16 50 AM Screen Shot 2020-04-09 at 11 17 26 AM Screen Shot 2020-04-09 at 11 18 11 AM

📋 QA

These buttons are hidden, this PR is just so I can access them when I add functionality.

Story 📖

NT-1111

@eoji
## fragment_pledge_section_footer.xml
5f8eb32 
- Added `pledge_footer_continue_button` button
- Added fake `pledge_footer_pledge_button_progress` button
@eoji eoji added the UI 🎨 label Apr 9, 2020
@eoji eoji requested a review from a team April 9, 2020 15:24
@eoji eoji mentioned this pull request Apr 9, 2020
Merged
ifbarrera
ifbarrera approved these changes Apr 9, 2020
View reviewed changes
Copy link
@ifbarrera ifbarrera left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if you'd want to add some padding around the progress indicator so that it has more space on the top and bottom relative to the button. Lgtm otherwise!

@eoji
Copy link
Contributor Author
eoji commented Apr 9, 2020

Yeah, I'm going to do a design sweep with Colleen after I'm all done. Ty, adding that to the list!

@eoji eoji merged commit e25c27d into NT-1103 Apr 9, 2020
@eoji eoji deleted the NT-1111 branch April 9, 2020 18:43
@eoji eoji mentioned this pull request Apr 13, 2020
Merged
eoji added a commit that referenced this pull request Apr 20, 2020
@eoji
[🎨] NT-1103 Pledge screen redesign (#837)
2553140 
* [🦶🏾] NT-1104 Add Pledge screen footer (#817)
* [⬇] NT-1120 Vertical payment methods in Pledge screen (#821)
* [🔨] NT-1121 Stored cards redesign (#822)
* [🛒] NT-1105 Kickstarter is not a store redesign (#823)
* [💳] NT-1122 Initial card selection (#824)
* [⏳] NT-1124 Loading state for payment methods (#825)
* [➕] NT-1125 New card CTA (#828)
* [💳] NT-1123 Last four digits copy (#826)
* [💳] NT-1123 Card not allowed copy (#827)
* [🎨] NT-1111 Adding 2 buttons in the new pledge footer (#830)
* [🔌] NT-1129 Adding progress state for pledging (#831)
* [🗣] NT-1126 Payment methods a11y (#829)
* [👷🏾‍♀️] NT-1128 Moved continue button in Pledge screen to footer (#833)
* [⚠️] NT-1131 Pledge error Toasts (#832)
* [␡] NT-1127 Removing Update pledge button (#834)
* [📝] NT-1130 Pledge button CTA (#835)
* [✅] NT-1133 Enabling pledge button only when all fields are valid (#836)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ifbarrera ifbarrera ifbarrera approved these changes

Assignees
No one assigned
Labels
UI 🎨
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eoji @ifbarrera
0