8000 [⬇] NT-1120 Vertical payment methods in Pledge screen by eoji · Pull Request #821 · kickstarter/android-oss · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

[⬇] NT-1120 Vertical payment methods in Pledge screen #821

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 3, 2020
Merged

[⬇] NT-1120 Vertical payment methods in Pledge screen #821

merged 1 commit into from
Apr 3, 2020

Conversation

eoji
Copy link
Contributor
@eoji eoji commented Apr 3, 2020 •
edited by jira bot
Loading

📲 What

Payment methods in the Pledge screen are now displayed vertically

🤔 Why

This is the first step in the payment methods redesign.

🛠 How

  • cards_recycler orientation is now VERTICAL
  • Removed stored_card_width. All cards are now full width.

RewardCardItemDecoration

  • Removed special logic for stored cards margins

👀 See

After 🦋 Before 🐛
screenshot-2020-04-03_142224 screenshot-2020-04-03_141451

📋 QA

N/A

Story 📖

NT-1120

@eoji
- cards_recycler orientation is now VERTICAL
51a8580 
- Removed `stored_card_width`. All cards are now full width.
## `RewardCardItemDecaration`
- Removed special logic for stored cards margins
@eoji eoji added the UI 🎨 label Apr 3, 2020
@eoji eoji requested review from justinswart and cdolm92 April 3, 2020 18:28
cdolm92
cdolm92 approved these changes Apr 3, 2020
View reviewed changes
Copy link
@cdolm92 cdolm92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Paired w/ @eoji 👍🏾

@eoji eoji merged commit 70d2c79 into NT-1103 Apr 3, 2020
@eoji eoji deleted the NT-1120 branch April 3, 2020 21:10
@eoji eoji mentioned this pull request Apr 13, 2020
Merged
eoji added a commit that referenced this pull request Apr 20, 2020
@eoji
[🎨] NT-1103 Pledge screen redesign (#837)
2553140 
* [🦶🏾] NT-1104 Add Pledge screen footer (#817)
* [⬇] NT-1120 Vertical payment methods in Pledge screen (#821)
* [🔨] NT-1121 Stored cards redesign (#822)
* [🛒] NT-1105 Kickstarter is not a store redesign (#823)
* [💳] NT-1122 Initial card selection (#824)
* [⏳] NT-1124 Loading state for payment methods (#825)
* [➕] NT-1125 New card CTA (#828)
* [💳] NT-1123 Last four digits copy (#826)
* [💳] NT-1123 Card not allowed copy (#827)
* [🎨] NT-1111 Adding 2 buttons in the new pledge footer (#830)
* [🔌] NT-1129 Adding progress state for pledging (#831)
* [🗣] NT-1126 Payment methods a11y (#829)
* [👷🏾‍♀️] NT-1128 Moved continue button in Pledge screen to footer (#833)
* [⚠️] NT-1131 Pledge error Toasts (#832)
* [␡] NT-1127 Removing Update pledge button (#834)
* [📝] NT-1130 Pledge button CTA (#835)
* [✅] NT-1133 Enabling pledge button only when all fields are valid (#836)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cdolm92 cdolm92 cdolm92 approved these changes

@justinswart justinswart Awaiting requested review from justinswart

Assignees
No one assigned
Labels
UI 🎨
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eoji @cdolm92
0