[🛤] NT-656 Login signup events #779
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- 8000 Added `LakeEvent.LOG_IN_OR_SIGNUP_BUTTON_CLICKED ` with value `"Log In or Signup Button Clicked"` - Added `Koala.trackLogInSignUpButtonClicked` - Tracking when a not logged in user clicks the tout button in `DiscoveryFragmentViewModel` - Added separate test for `showLoginTest` in `DiscoveryFragmentViewModelTest`
- Added `LakeEvent.LOG_IN_OR_SIGN_UP_PAGE_VIEWED` with value `"Log In or Sign Up Page Viewed"` - Added `Koala.trackLogInSignUpPageViewed` to track when a user lands on the login tout screen. - Tracking `LOG_IN_OR_SIGN_UP_PAGE_VIEWED` in `LoginToutViewModel` - There were no tracking tests in `LoginToutViewModelTest` so I added tests for the Data Lake.
- Added `LakeEvent.FACEBOOK_LOG_IN_OR_SIGNUP_BUTTON_CLICKED ` with value `"Facebook Log In or Signup Button Clicked"` - Added `Koala.trackFacebookLogInSignUpButtonClicked ` - Tracking when a not logged in user clicks the Facebook sign in button in `LoginToutViewModel` - Updated tests `DiscoveryFragmentViewModelTest`
- Added `LakeEvent.LOG_IN_BUTTON_CLICKED` with value `"Log In Button Clicked"` - Added `Koala.trackLogInButtonClicked` to track when a user clicks on the log in button in the `LoginToutActivity`. - Tracking `LOG_IN_BUTTON_CLICKED` in `LoginToutViewModel` - Added test in `LoginToutViewModelTest`
- Added `LakeEvent.SIGN_UP_BUTTON_CLICKED` with value `"Sign Up Button Clicked"` - Added `Koala.trackSignUpButtonClicked` to track when a user clicks on the sign up button in the `LoginToutActivity`. - Tracking `SIGN_UP_BUTTON_CLICKED` in `LoginToutViewModel` when user clicks the sign up button - Added test in `LoginToutViewModelTest`
- Added `LakeEvent.LOG_IN_SUBMIT_BUTTON_CLICKED` with value `"Log In Submit Button Clicked"` - Added `Koala.trackLogInSubmitButtonClicked` to track when a user clicks the log in button in the `LoginActivity` - Tracking `LOG_IN_SUBMIT_BUTTON_CLICKED` in `LoginViewModel` when user clicks the log in button - Added test in `LoginViewModelTest`
- Added `LakeEvent.SIGN_UP_SUBMIT_BUTTON_CLICKED` with value `"Sign Up Submit Button Clicked"` - Added `Koala.trackLogInSubmitButtonClicked` to track when a user clicks the sign up button in the `SignupActivity` - Tracking `SIGN_UP_SUBMIT_BUTTON_CLICKED` in `SignupViewModel` when user clicks the log in button - Added test in `SignupViewModelTest`
- Added `LakeEvent.FORGOT_PASSWORD_PAGE_VIEWED` with value `"Forgot Password Page Viewed"` - Added `Koala.trackForgotPasswordPageViewed` to track when a user views the `ResetPasswordActivity` - Tracking `FORGOT_PASSWORD_PAGE_VIEWED` in `SignupViewModel` when user clicks the reset password button - Added test in `ResetPasswordViewModelTest`
- Added `LakeEvent.TWO_FACTOR_CONFIRMATION_VIEWED` with value `"Two-Factor Confirmation Viewed"` - Added `Koala.trackTwoFactorConfirmationViewed` to track when a user views the `TwoFactorActivity` - Tracking `TWO_FACTOR_CONFIRMATION_VIEWED` in `TwoFactorViewModel` when user views the 2FA screen - Added tests in `TwoFactorViewModelTest`
jgsamudio
approved these changes
Mar 5, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📲 What
Log in/sign up events.
🤔 Why
We have new Log in/sign up events.
🛠 How
[🛤] NT-917 Log In or Signup Button Clicked event (#760)
[🛤] NT-918 Log In or Sign Up Page Viewed events (#761)
[🛤] NT-919 Facebook Log In or Signup Button Clicked event (#762)
[🛤] NT-920 Log In Button Clicked event (#763)
[🛤] NT-921 Sign Up Button Clicked event (#764)
[🛤] NT-922 Log In Submit Button Clicked event (#765)
[🛤] NT-923 Sign Up Submit Button Clicked event (#766)
[🛤] NT-924 Forgot Password Page Viewed event (#767)
[🛤] NT-925 Two-Factor Confirmation Viewed event (#768)
👀 See
No visuals!
📋 QA
So many ways 2 QA:
ktkthe staging lakeLogcatin Android Studiodevproject in AmplitudeStory 📖
NT-656