[🛤] NT-925 Two-Factor Confirmation Viewed event #768
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…actor Confirmation Viewed"` - Added `Koala.trackForgotPasswordPageViewed` to track when a user views the `TwoFactorActivity` - Tracking `TWO_FACTOR_CONFIRMATION_VIEWED` in `TwoFactorViewModel` when user views the 2FA screen - Added tests in `TwoFactorViewModelTest`
jgsamudio
approved these changes
Feb 26, 2020
# Conflicts: # app/src/main/java/com/kickstarter/libs/Koala.java # app/src/main/java/com/kickstarter/libs/LakeEvent.kt
eoji
added a commit
that referenced
this pull request
Mar 5, 2020
[🛤] NT-917 Log In or Signup Button Clicked event (#760) [🛤] NT-918 Log In or Sign Up Page Viewed events (#761) [🛤] NT-919 Facebook Log In or Signup Button Clicked event (#762) [🛤] NT-920 Log In Button Clicked event (#763) [🛤] NT-921 Sign Up Button Clicked event (#764) [🛤] NT-922 Log In Submit Button Clicked event (#765) [🛤] NT-923 Sign Up Submit Button Clicked event (#766) [🛤] NT-924 Forgot Password Page Viewed event (#767) [🛤] NT-925 Two-Factor Confirmation Viewed event (#768)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📲 What
Adding
Two-Factor Confirmation Viewedevent.🤔 Why
We have new Log In or Signup events.
🛠 How
LakeEvent.TWO_FACTOR_CONFIRMATION_VIEWEDwith value"Two-Factor Confirmation Viewed"Koala.trackTwoFactorConfirmationViewedto track when a user views theTwoFactorActivityTWO_FACTOR_CONFIRMATION_VIEWEDinTwoFactorViewModelwhen user views the 2FA screenTwoFactorViewModelTest👀 See
No visual changes.
📋 QA
So many ways 2 QA:
ktkthe staging lakeLogcatin Android Studiodevproject in AmplitudeStory 📖
NT-925