kickstarter · eoji · Sep 30, 2019 · Sep 26, 2019 · Sep 26, 2019
diff --git a/app/src/main/java/com/kickstarter/libs/RefTag.java b/app/src/main/java/com/kickstarter/libs/RefTag.java
@@ -98,4 +98,8 @@ public static RefTag from(final @NonNull String tag) {
   public static @NonNull RefTag update() {
     return new AutoParcel_RefTag("update");
   }
+
+  public static @NonNull RefTag updateShare() {
+    return new AutoParcel_RefTag("android_update_share");
+  }
 }
diff --git a/app/src/main/java/com/kickstarter/ui/activities/UpdateActivity.java b/app/src/main/java/com/kickstarter/ui/activities/UpdateActivity.java
@@ -126,14 +126,16 @@ private void startProjectActivity(final @NonNull Project project, final @NonNull
     startActivityWithTransition(intent, R.anim.slide_in_right, R.anim.fade_out_slide_out_left);
   }
 
-  private void startShareIntent(final @NonNull Update update) {
+  private void startShareIntent(final @NonNull Pair<Update, String> updateAndShareUrl) {
+    final Update update = updateAndShareUrl.first;
+    final String shareUrl = updateAndShareUrl.second;
     final String shareMessage = this.ksString.format(this.shareUpdateCountString, "update_count", NumberUtils.format(update.sequence()))
       + ": " + update.title();
 
     final Intent intent = new Intent(Intent.ACTION_SEND)
       .setType("text/plain")
-      .putExtra(Intent.EXTRA_TEXT, shareMessage + " " + update.urls().web().update());
-    startActivity(intent);
+      .putExtra(Intent.EXTRA_TEXT, shareMessage + " " + shareUrl);
+    startActivity(Intent.createChooser(intent, getString(R.string.Share_update)));
   }
 
   @Override

diff --git a/app/src/main/java/com/kickstarter/viewmodels/UpdateViewModel.java b/app/src/main/java/com/kickstarter/viewmodels/UpdateViewModel.java
@@ -7,6 +7,7 @@
 import com.kickstarter.libs.KoalaContext;
 import com.kickstarter.libs.RefTag;
 import com.kickstarter.libs.utils.NumberUtils;
+import com.kickstarter.libs.utils.UrlUtils;
 import com.kickstarter.models.Project;
 import com.kickstarter.models.Update;
 import com.kickstarter.services.ApiClientType;
@@ -44,7 +45,7 @@ interface Inputs {
 
   interface Outputs {
     /** Emits when we should start the share intent to show the share sheet. */
-    Observable<Update> startShareIntent();
+    Observable<Pair<Update, String>> startShareIntent();
 
     /** Emits an update to start the comments activity with. */
     Observable<Update> startCommentsActivity();
@@ -96,6 +97,7 @@ public ViewModel(final @NonNull Environment environment) {
 
       currentUpdate
         .compose(takeWhen(this.shareButtonClicked))
+        .map(update -> Pair.create(update, UrlUtils.INSTANCE.appendRefTag(update.urls().web().update(), RefTag.updateShare().tag())))
         .compose(bindToLifecycle())
         .subscribe(this.startShareIntent::onNext);
 
@@ -139,7 +141,7 @@ public ViewModel(final @NonNull Environment environment) {
     private final PublishSubject<Request> goToUpdateRequest = PublishSubject.create();
     private final PublishSubject<Void> shareButtonClicked = PublishSubject.create();
 
-    private final PublishSubject<Update> startShareIntent = PublishSubject.create();
+    private final PublishSubject<Pair<Update, String>> startShareIntent = PublishSubject.create();
     private final PublishSubject<Update> startCommentsActivity = PublishSubject.create();
     private final PublishSubject<Pair<Project, RefTag>> startProjectActivity = PublishSubject.create();
     private final BehaviorSubject<String> updateSequence = BehaviorSubject.create();
@@ -164,7 +166,7 @@ public ViewModel(final @NonNull Environment environment) {
       this.shareButtonClicked.onNext(null);
     }
 
-    @Override public Observable<Update> startShareIntent() {
+    @Override public Observable<Pair<Update, String>> startShareIntent() {
       return this.startShareIntent;
     }
     @Override public @NonNull Observable<Update> startCommentsActivity() {

diff --git a/app/src/test/java/com/kickstarter/viewmodels/UpdateViewModelTest.java b/app/src/test/java/com/kickstarter/viewmodels/UpdateViewModelTest.java
@@ -1,16 +1,19 @@
 package com.kickstarter.viewmodels;
 
 import android.content.Intent;
+import android.util.Pair;
 
 import com.kickstarter.KSRobolectricTestCase;
 import com.kickstarter.libs.Environment;
 import com.kickstarter.libs.KoalaEvent;
 import com.kickstarter.libs.utils.NumberUtils;
 import com.kickstarter.mock.factories.ProjectFactory;
 import com.kickstarter.mock.factories.UpdateFactory;
+import com.kickstarter.mock.factories.UserFactory;
 import com.kickstarter.mock.services.MockApiClient;
 import com.kickstarter.models.Project;
 import com.kickstarter.models.Update;
+import com.kickstarter.models.User;
 import com.kickst
B5C8
arter.services.ApiClientType;
 import com.kickstarter.ui.IntentKey;
 
@@ -144,9 +147,25 @@ public void testUpdateViewModel_StartProjectActivity() {
   public void testUpdateViewModel_StartShareIntent() {
     final UpdateViewModel.ViewModel vm = new UpdateViewModel.ViewModel(environment());
 
-    final Update update = UpdateFactory.update();
+    final User creator = UserFactory.creator().toBuilder().id(278438049).build();
+    final Project project = ProjectFactory.project().toBuilder().creator(creator).build();
+    final String updatesUrl = "https://www.kck.str/projects/" + project.creator().param() + "/" + project.param() + "/posts";
+
+    final int id = 15;
+
+    final Update.Urls.Web web = Update.Urls.Web.builder()
+      .update(updatesUrl + "/" + id)
+      .likes(updatesUrl + "/likes")
+      .build();
+
+    final Update update = UpdateFactory.update()
+      .toBuilder()
+      .id(id)
+      .projectId(project.id())
+      .urls(Update.Urls.builder().web(web).build())
+      .build();
 
-    final TestSubscriber<Update> startShareIntent = new TestSubscriber<>();
+    final TestSubscriber<Pair<Update, String>> startShareIntent = new TestSubscriber<>();
     vm.outputs.startShareIntent().subscribe(startShareIntent);
 
     // Start the intent with a project and update.
@@ -156,7 +175,9 @@ public void testUpdateViewModel_StartShareIntent() {
     );
     vm.inputs.shareIconButtonClicked();
 
-    startShareIntent.assertValues(update);
+    final String expectedShareUrl = "https://www.kck.str/projects/" + project.creator().param() +
+      "/" + project.param() + "/posts/" + id + "?ref=android_update_share";
+    startShareIntent.assertValue(Pair.create(update, expectedShareUrl));
   }
 
   @Test