8000 [🔗] NT-342 Adding ref tag when sharing updates by eoji · Pull Request #622 · kickstarter/android-oss · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

[🔗] NT-342 Adding ref tag when sharing updates #622

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 30, 2019
Merged

[🔗] NT-342 Adding ref tag when sharing updates #622

merged 2 commits into from
Sep 30, 2019

Conversation

eoji
Copy link
Contributor
@eoji eoji commented Sep 26, 2019 •
edited
Loading

📲 What

Adding a ref tag when sharing an update.

🤔 Why

So we know if users navigated to an update page via a link shared from the Android app!

🛠 How

  • Added RefTag.updateShare which has a value of android_update_share.
  • The startShareIntent output in UpdateViewModel now outputs a pair of an update and the share url string.
  • Updated intent share style in UpdateActivity.
  • Tests.

👀 See

Before 🐛 After 🦋
Update #31: A calm before the storm: daily unlock! WIPs! https://www.kickstarter.com/projects/1492106834/aeon-trespass-odyssey/posts/2635180 Update #31: A calm before the storm: daily unlock! WIPs! https://www.kickstarter.com/projects/1492106834/aeon-trespass-odyssey/posts/2635180?ref=android_update_share

📋 QA

Click the share icon in an update page and check out that SWEET ref tag.

Story 📖

NT-342

eoji added 2 commits September 26, 2019 15:59
@eoji
Added RefTag.updateShare which has a value of
4918b1e 
native_android_update_share.
startShareIntent output in UpdatesViewModel now outputs a pair of an update and the share url string.
Updated intent share style in UpdateActivity.
Tests.
@eoji
removing android_ prefex
c5835d2
@eoji eoji requested a review from a team September 26, 2019 20:45
@eoji eoji changed the title [🔗] Adding ref tag when sharing updates [🔗] NT-342 Adding ref tag when sharing updates Sep 27, 2019
setsun
setsun approved these changes Sep 30, 2019
View reviewed changes
Copy link
@setsun setsun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM!

@eoji eoji merged commit e6d2c48 into master Sep 30, 2019
@eoji eoji deleted the NT-342 branch September 30, 2019 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@setsun setsun setsun approved these changes

Assignees
No one assigned
Labels
feature ✨
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eoji @setsun
0