NT-1616: Shipping location retention when changing reward #1021
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ddOns, edit reward -> being able to select that reward again to allow modify addOns
…er/android-oss into imartin/NT-1616
…should use the backing shipping rule on AddOns screen. - On pledge fragment, if user skips addOns use the backingShippingRule, otherwise use the shippingRule in pledgeData Object.
- added new test for changing location
…starter/android-oss into imartin/NT-1616
| @@ -1504,6 +1526,11 @@ interface PledgeFragmentViewModel { | |||
| return shippingCost | |||
| } | |||
|
|
|||
| /** | |||
| * When retrieving the backing shipping information we do have available the LocationId on the backingObject | |||
| * and the list of shippingRules available for the selected reward, so we the backing shippingRule will be | |||
There was a problem hiding this comment.
nit: change so we the backing shippingRule will be to the backing shippingRule will be
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📲 What
🤔 Why
👀 See
Before When modifying addOns selection the selected shippingRule was the default one, instead of the backed shippingRule.
NOW After pledging with addOns with shippingLocation, if you edit the addOns the shipping location you'll see at the AddOns screen will be the backed one.
Before When pledging to a reward with available addOns but skipping them, updating reward, select addOn, go to pledge screen, the shipping was the default one, instead of the chosen on AddOns screen.
NOW When pledging to a reward with available addOns but skipping them, updating reward, select addOn, go to pledge screen, the shipping is the chosen one for addOns screen
Before editting reward, delete all addOns selection, on pledge screen not able to edit shipping selection
Now editting reward, delete all addOns selection, on pledge screen shipping rule selector available to edit shipping
| | |
📋 QA
Case 1
Case 2
Case 3
Story 📖
NT-1616