8000 NT-1615: fix Edit reward when add-ons were available but not backed by Arkariang · Pull Request #1019 · kickstarter/android-oss · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

NT-1615: fix Edit reward when add-ons were available but not backed #1019

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 19, 2020
Merged

NT-1615: fix Edit reward when add-ons were available but not backed #1019

merged 2 commits into from
Oct 19, 2020

Conversation

Arkariang
Copy link
Contributor

📲 What

  • Allow a editing an available reward with available addOns but not backed addOns

👀 See

select-same-reward-no-addOns

| | |

📋 QA

  • Pledge to a reward with available addOns, but skip the addOns

  • Before Edit reward -> The button for selecting the same reward not available

  • NOW Edit reward -> The button for selecting the same reward is available letting the user modify the addOns selection

Story 📖

NT-1615

@Arkariang
- version code
327d216
@Arkariang
- Use case: backed a reward with available addOns but not baked any a…
a497894 
…ddOns, edit reward -> being able to select that reward again to allow modify addOns
@Arkariang Arkariang self-assigned this Oct 16, 2020
@Arkariang Arkariang marked this pull request as ready for review October 16, 2020 18:07
leighdouglas
leighdouglas approved these changes Oct 19, 2020
View reviewed changes
Copy link
Contributor
@leighdouglas leighdouglas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Arkariang Arkariang merged commit 1177d38 into feature/NT-1536-Android-Add-ons-San Oct 19, 2020
@Arkariang Arkariang deleted the imartin/NT-1615-fix-addOns-bug branch October 19, 2020 15:42
Arkariang added a commit that referenced this pull request Oct 28, 2020
@Arkariang @leighdouglas
NT-1536:Android add ons san -(2.10.0)
9d58e17 
* NT-1615: fix Edit reward when add-ons were available but not backed (#1019)
* NT-1479: Android Pledge Screen Polish (#1020)
* NT-1616: Shipping location retention when changing reward (#1021)
* NT-1615: copy change (#1025)

Co-authored-by: leighdouglas <leighcdouglas1@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leighdouglas leighdouglas leighdouglas approved these changes

@jgsamudio jgsamudio Awaiting requested review from jgsamudio

Assignees

@Arkariang Arkariang

Labels
bug 🐛
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Arkariang @leighdouglas
0