8000 vietnam updating by Cathaylaboratory · Pull Request #3562 · keymanapp/keyboards · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

vietnam updating #3562

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jun 16, 2025
Merged

vietnam updating #3562

merged 6 commits into from
Jun 16, 2025

Conversation

Cathaylaboratory
Copy link
Contributor

ready for reviewing

ready for reviewing
@keyman-server
Copy link
Collaborator

Thank you for your pull request. You'll see a "build failed" message until the Keyman team has reviewed the pull request and manually initiated the build process.

Every change committed to this branch will become part of this pull request. When you have finished submitting files and are ready for the Keyman team to review this pull request, please post a "Ready for review" comment.

@Cathaylaboratory
Copy link
Contributor Author
Cathaylaboratory commented Jun 10, 2025 via email

@LornaSIL
Copy link
Contributor

Can you remove the [K_TAB] rules? We should never have approved a keyboard with that key used this way.

@Cathaylaboratory
Copy link
Contributor Author
Cathaylaboratory commented Jun 10, 2025 via email

@Cathaylaboratory
Copy link
Contributor Author
Cathaylaboratory commented Jun 10, 2025 via email

@Cathaylaboratory
Copy link
Contributor Author
Cathaylaboratory commented Jun 13, 2025 via email

@LornaSIL
Copy link
Contributor
LornaSIL commented Jun 13, 2025 via email

@DavidLRowe
Copy link
Contributor

@Cathaylaboratory For typing logographic scripts or handling large sets of rules, you may find RIME (https://rime.im/) to be a better fit. In the article How to advance your language to the digital / AI age there's a section on "Input methods and keyboards" that describes RIME: "You only need some basic knowledge of regular expressions to build an IME for any language. Here is an example of building an Ugaritic keyboard https://github.com/laubonghaudoi/rime-ugaritic You only need to provide a lexicon and a rule mapping file, then deploy to the engine and you can type it just as any other language."

I've not used it myself so I could be totally wrong, but I'm wondering if it would better suit the keyboards you're creating.

@Cathaylaboratory
Copy link
Contributor Author
Cathaylaboratory commented Jun 13, 2025 via email 8000

@Cathaylaboratory
Copy link
Contributor Author
Cathaylaboratory commented Jun 13, 2025 via email

@Cathaylaboratory
Copy link
Contributor Author
Cathaylaboratory commented Jun 14, 2025 via email

@andjc
Copy link
Contributor
andjc commented Jun 14, 2025

From memory in Windows, the TAB key has two different functions in the Japanese IME:

  • Before focus is in the candidate window: Enter the prediction candidate window
  • With focus in the candidate window: Move the selection down.

This is a feature built into Window's IME code base, it isn't part of their keyboard layout code base. If I remember correctly.

If I am understanding your request correctly you want to add certain IME functionality to a keyboard layout?

@andjc
Copy link
Contributor
andjc commented Jun 14, 2025

Wouldn't word selection be better handled by the lexical models? And improving support for text prediction instead?

@Cathaylaboratory
Copy link
Contributor Author
Cathaylaboratory commented Jun 15, 2025 via email

@Cathaylaboratory
Copy link
Contributor Author
Cathaylaboratory commented Jun 15, 2025 via email

@andjc
Copy link
Contributor
andjc commented Jun 15, 2025 via email

@Cathaylaboratory
Copy link
Contributor Author
Cathaylaboratory commented Jun 15, 2025 via email

@andjc
Copy link
Contributor
andjc commented Jun 15, 2025 via email

@Cathaylaboratory
Copy link
Contributor Author
Cathaylaboratory commented Jun 15, 2025 via email

Can you approve that?
@Cathaylaboratory
Copy link
Contributor Author
Cathaylaboratory commented Jun 15, 2025 via email

@LornaSIL
Copy link
Contributor

I suppose you can call it censorship, but that's part of working with a GitHub repository, we do code review. We have to protect the functioning of the Keyman build system and the keyboard packages so that our users have the best experience possible. Unfortunately, I don't think I should have approved your reusing the TAB key this way previously, but since I did approve it, you can keep those prior rules. Thank you for addressing the concerns.

Copy link
Contributor
@LornaSIL LornaSIL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved.

@Cathaylaboratory
Copy link
Contributor Author
Cathaylaboratory commented Jun 16, 2025 via email

@Cathaylaboratory
Copy link
Contributor Author
Cathaylaboratory commented Jun 16, 2025 via email

@DavidLRowe DavidLRowe merged commit 26e8f8a into keymanapp:master Jun 16, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants
0