8000 fix: Prevent submitting acc results to AMP on PR by mrCherry97 · Pull Request #3730 · kyma-project/busola · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix: Prevent submitting acc results to AMP on PR #3730

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Mar 3, 2025
Merged

fix: Prevent submitting acc results to AMP on PR #3730

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
4194ee7
try something different
mrCherry97 Feb 27, 2025
8f174c1
try something different
mrCherry97 Feb 27, 2025
2df0329
try something different
mrCherry97 Feb 27, 2025
6bcf724
try something different
mrCherry97 Feb 27, 2025
50cf736
idk what I'm doing, copilot fixed that
mrCherry97 Feb 27, 2025
a86d674
idk what I'm doing, copilot fixed that
mrCherry97 Feb 27, 2025
3030898
idk what I'm doing, Halama fixed that
mrCherry97 Feb 27, 2025
8d92c3f
Merge branch 'main' of github.com:kyma-project/busola into acc-pr-2
mrCherry97 Mar 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/accessibility-tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ jobs:
shell: bash
env:
ACC_AMP_TOKEN: ${{ secrets.ACC_AMP_TOKEN }}
IS_PR: ${{ github.event_name == 'pull_request' || github.event_name == 'pull_request_target' }}
IS_PR: ${{ github.event_name }} == 'pull_request' || ${{ github.event_name }} == 'pull_request_target'
run: |
k3d kubeconfig get kyma > tests/integration/fixtures/kubeconfig.yaml
export CYPRESS_DOMAIN=http://localhost:3001
Expand Down
2 changes: 1 addition & 1 deletion tests/integration/plugins/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ module.exports = (on, config) => {
'/' +
date.getDate() +
'-' +
(date.getUTCHours() + 2) +
(date.getUTCHours() + 1) +
':' +
date.getUTCMinutes();
const reportName = `AMP_REPORT_${todaysDate}`;
Expand Down
6 changes: 4 additions & 2 deletions tests/integration/tests/accessibility/test-acc-cluster.spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,8 @@ context('Accessibility test Cluster list and overview', () => {
.runAllAccessibilityTests()
.printAccessibilityTestResults();

if (Cypress.env('IS_PR') !== true)
if (Cypress.env('IS_PR') === true) cy.log('Skipping AMP submission for PR');
else
cy.submitAccessibilityConcernsToAMP(
Cypress.env('AMP_REPORT_NAME'),
'Clusters list',
Expand All @@ -28,7 +29,8 @@ context('Accessibility test Cluster list and overview', () => {

cy.runAllAccessibilityTests().printAccessibilityTestResults();

if (Cypress.env('IS_PR') !== true)
if (Cypress.env('IS_PR') === true) cy.log('Skipping AMP submission for PR');
else
cy.submitAccessibilityConcernsToAMP(
Cypress.env('AMP_REPORT_NAME'),
'Cluster overview',
Expand Down
9 changes: 6 additions & 3 deletions tests/integration/tests/accessibility/test-acc-cron-jobs.spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,8 @@ context('Accessibility test Cron Jobs', () => {

cy.runAllAccessibilityTests().printAccessibilityTestResults();

if (Cypress.env('IS_PR') !== true)
if (Cypress.env('IS_PR') === true) cy.log('Skipping AMP submission for PR');
else
cy.submitAccessibilityConcernsToAMP(
Cypress.env('AMP_REPORT_NAME'),
'Cron Jobs list',
Expand All @@ -51,7 +52,8 @@ context('Accessibility test Cron Jobs', () => {

cy.runAllAccessibilityTests().printAccessibilityTestResults();

if (Cypress.env('IS_PR') !== true)
if (Cypress.env('IS_PR') === true) cy.log('Skipping AMP submission for PR');
else
cy.submitAccessibilityConcernsToAMP(
Cypress.env('AMP_REPORT_NAME'),
'Cron Jobs create',
Expand Down Expand Up @@ -134,7 +136,8 @@ context('Accessibility test Cron Jobs', () => {

cy.runAllAccessibilityTests().printAccessibilityTestResults();

if (Cypress.env('IS_PR') !== true)
if (Cypress.env('IS_PR') === true) cy.log('Skipping AMP submission for PR');
else
cy.submitAccessibilityConcernsToAMP(
Cypress.env('AMP_REPORT_NAME'),
'Cron Jobs details',
Expand Down
9 changes: 6 additions & 3 deletions tests/integration/tests/accessibility/test-acc-custom-resoureces.spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,8 @@ context('Accessibility test Custom Resources', () => {

cy.runAllAccessibilityTests().printAccessibilityTestResults();

if (Cypress.env('IS_PR') !== true)
if (Cypress.env('IS_PR') === true) cy.log('Skipping AMP submission for PR');
else
cy.submitAccessibilityConcernsToAMP(
Cypress.env('AMP_REPORT_NAME'),
'Custom Resources overview',
Expand All @@ -56,7 +57,8 @@ context('Accessibility test Custom Resources', () => {

cy.runAllAccessibilityTests().printAccessibilityTestResults();

if (Cypress.env('IS_PR') !== true)
if (Cypress.env('IS_PR') === true) cy.log('Skipping AMP submission for PR');
else
cy.submitAccessibilityConcernsToAMP(
Cypress.env('AMP_REPORT_NAME'),
'Custom Resources single list',
Expand Down Expand Up @@ -89,7 +91,8 @@ context('Accessibility test Custom Resources', () => {

cy.runAllAccessibilityTests().printAccessibilityTestResults();

if (Cypress.env('IS_PR') !== true)
if (Cypress.env('IS_PR') === true) cy.log('Skipping AMP submission for PR');
else
cy.submitAccessibilityConcernsToAMP(
Cypress.env('AMP_REPORT_NAME'),
'Tcluster Custom Resource details',
Expand Down
9 changes: 6 additions & 3 deletions tests/integration/tests/accessibility/test-acc-extensions.spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,8 @@ context('Accessibility test Extensions view', () => {

cy.runAllAccessibilityTests().printAccessibilityTestResults();

if (Cypress.env('IS_PR') !== true)
if (Cypress.env('IS_PR') === true) cy.log('Skipping AMP submission for PR');
else
cy.submitAccessibilityConcernsToAMP(
Cypress.env('AMP_REPORT_NAME'),
'Extensions list',
Expand All @@ -57,7 +58,8 @@ context('Accessibility test Extensions view', () => {

cy.runAllAccessibilityTests().printAccessibilityTestResults();

if (Cypress.env('IS_PR') !== true)
if (Cypress.env('IS_PR') === true) cy.log('Skipping AMP submission for PR');
else
cy.submitAccessibilityConcernsToAMP(
Cypress.env('AMP_REPORT_NAME'),
'Extensions create',
Expand All @@ -78,7 +80,8 @@ context('Accessibility test Extensions view', () => {

cy.runAllAccessibilityTests().printAccessibilityTestResults();

if (Cypress.env('IS_PR') !== true)
if (Cypress.env('IS_PR') === true) cy.log('Skipping AMP submission for PR');
else
cy.submitAccessibilityConcernsToAMP(
Cypress.env('AMP_REPORT_NAME'),
'Extensions details',
Expand Down
9 changes: 6 additions & 3 deletions tests/integration/tests/accessibility/test-acc-modules.spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,8 @@ context('Accessibility test Modules view', () => {

cy.runAllAccessibilityTests().printAccessibilityTestResults();

if (Cypress.env('IS_PR') !== true)
if (Cypress.env('IS_PR') === true) cy.log('Skipping AMP submission for PR');
else
cy.submitAccessibilityConcernsToAMP(
Cypress.env('AMP_REPORT_NAME'),
'Modules view',
Expand All @@ -32,7 +33,8 @@ context('Accessibility test Modules view', () => {

cy.runAllAccessibilityTests().printAccessibilityTestResults();

if (Cypress.env('IS_PR') !== true)
if (Cypress.env('IS_PR') === true) cy.log('Skipping AMP submission for PR');
else
cy.submitAccessibilityConcernsToAMP(
Cypress.env('AMP_REPORT_NAME'),
'Add Modules view',
Expand Down Expand Up @@ -64,7 +66,8 @@ context('Accessibility test Modules view', () => {

cy.runAllAccessibilityTests().printAccessibilityTestResults();

if (Cypress.env('IS_PR') !== true)
if (Cypress.env('IS_PR') === true) cy.log('Skipping AMP submission for PR');
else
cy.submitAccessibilityConcernsToAMP(
Cypress.env('AMP_REPORT_NAME'),
'Edit Modules view',
Expand Down
3 changes: 2 additions & 1 deletion tests/integration/tests/accessibility/test-acc-namespace-overview.spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,8 @@ context('Accessibility test Namespace overview', () => {

cy.runAllAccessibilityTests().printAccessibilityTestResults();

if (Cypress.env('IS_PR') !== true)
if (Cypress.env('IS_PR') === true) cy.log('Skipping AMP submission for PR');
else
cy.submitAccessibilityConcernsToAMP(
Cypress.env('AMP_REPORT_NAME'),
'Namespace overview',
Expand Down
3 changes: 2 additions & 1 deletion tests/integration/tests/accessibility/test-acc-performance.spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,8 @@ context('Accessibility test Cluster list and overview', () => {

cy.runAllAccessibilityTests().printAccessibilityTestResults();

if (Cypress.env('IS_PR') !== true)
if (Cypress.env('IS_PR') === true) cy.log('Skipping AMP submission for PR');
else
cy.submitAccessibilityConcernsToAMP(
Cypress.env('AMP_REPORT_NAME'),
'Performance panel',
Expand Down
9 changes: 6 additions & 3 deletions tests/integration/tests/accessibility/test-acc-pizzas.spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,8 @@ context('Accessibility test Pizza Orders', () => {

cy.runAllAccessibilityTests().printAccessibilityTestResults();

if (Cypress.env('IS_PR') !== true)
if (Cypress.env('IS_PR') === true) cy.log('Skipping AMP submission for PR');
else
cy.submitAccessibilityConcernsToAMP(
Cypress.env('AMP_REPORT_NAME'),
'Pizza Orders list',
Expand All @@ -91,7 +92,8 @@ context('Accessibility test Pizza Orders', () => {

cy.runAllAccessibilityTests().printAccessibilityTestResults();

if (Cypress.env('IS_PR') !== true)
if (Cypress.env('IS_PR') === true) cy.log('Skipping AMP submission for PR');
else
cy.submitAccessibilityConcernsToAMP(
Cypress.env('AMP_REPORT_NAME'),
'Pizza Orders create',
Expand All @@ -107,7 +109,8 @@ context('Accessibility test Pizza Orders', () => {

cy.runAllAccessibilityTests().printAccessibilityTestResults();

if (Cypress.env('IS_PR') !== true)
if (Cypress.env('IS_PR') === true) cy.log('Skipping AMP submission for PR');
else
cy.submitAccessibilityConcernsToAMP(
Cypress.env('AMP_REPORT_NAME'),
'Pizza Orders details',
Expand Down
Loading
0