8000 fix: Prevent submitting acc results to AMP on PR by mrCherry97 · Pull Request #3730 · kyma-project/busola · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix: Prevent submitting acc results to AMP on PR #3730

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Mar 3, 2025
Merged

fix: Prevent submitting acc results to AMP on PR #3730

merged 8 commits into from
Mar 3, 2025

Conversation

mrCherry97
Copy link
Contributor
@mrCherry97 mrCherry97 commented Feb 26, 2025 •
edited
Loading

Description

Changes proposed in this pull request:

  • fix: Prevent submitting acc results to AMP on PR

Related issue(s)

Definition of done

  • The PR's title starts with one of the following prefixes:
    • feat: A new feature
    • fix: A bug fix
    • docs: Documentation only changes
    • refactor: A code change that neither fixes a bug nor adds a feature
    • test: Adding tests
    • revert: Revert commit
    • chore: Maintainance changes to the build process or auxiliary tools, libraries, workflows, etc.
  • Related issues are linked. To link internal trackers, use the issue IDs like backlog#4567
  • Explain clearly why you created the PR and what changes it introduces
  • All necessary steps are delivered, for example, tests, documentation, merging

@kyma-bot kyma-bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 26, 2025
@mrCherry97 mrCherry97 marked this pull request as ready for review February 26, 2025 13:59
@kyma-bot kyma-bot added cla: yes Indicates the PR's author has signed the CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. labels Feb 26, 2025
@kyma-bot kyma-bot added the lgtm Looks good to me! label Feb 27, 2025
@mrCherry97 mrCherry97 enabled auto-merge (squash) March 3, 2025 10:18
@kyma-bot kyma-bot removed the lgtm Looks good to me! label Mar 3, 2025
@kyma-bot
Copy link
Contributor
kyma-bot commented Mar 3, 2025

New changes are detected. LGTM label has been removed.

@mrCherry97 mrCherry97 added the lgtm Looks good to me! label Mar 3, 2025
@mrCherry97 mrCherry97 merged commit c0af6bb into kyma-project:main Mar 3, 2025
28 of 37 checks passed
@mrCherry97 mrCherry97 deleted the acc-pr-2 branch March 3, 2025 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dbadura dbadura dbadura approved these changes

@akucharska akucharska Awaiting requested review from akucharska akucharska is a code owner

@chriskari chriskari Awaiting requested review from chriskari chriskari is a code owner

@OliwiaGowor OliwiaGowor Awaiting requested review from OliwiaGowor OliwiaGowor is a code owner

Assignees

@dbadura dbadura

Labels
cla: yes Indicates the PR's author has signed the CLA. lgtm Looks good to me! size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mrCherry97 @kyma-bot @dbadura
0