8000 fix: exit codes on tasks by tedim52 · Pull Request #2654 · kurtosis-tech/kurtosis · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix: exit codes on tasks #2654

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 17 commits into from
Feb 26, 2025
Merged

fix: exit codes on tasks #2654

merged 17 commits into from
Feb 26, 2025

Conversation

tedim52
Copy link
Collaborator
@tedim52 tedim52 commented Feb 19, 2025 •
edited
Loading

Description

... and adds acceptable_codes and skip_code_check fields to plan.run-sh and plan.run_python, similar to plan.exec

Exit codes on tasks were broken by this change - the exit code was from the last echo which was always 0 / success, meaning even if commandToRun failed, run_sh would return success. This fixes that issue by saving the exit code of the original commandToRun and exiting with that as the final step.

TODO:

  • update docs
  • add some acceptable code tests
  • remove reliance on bash if possible

Is this change user facing?

YES

References

#2499
Addresses #2649 and #2649

@tedim52 tedim52 force-pushed the tedi/acceptable-codes-fix branch from bd05dc8 to 9249664 Compare February 25, 2025 16:36
@tedim52
Copy link
Collaborator Author
tedim52 commented Feb 25, 2025

deploy docs CI job is failing which I need to fix but shouldn't block this PR

@tedim52 tedim52 requested a review from mieubrisse February 25, 2025 17:05
mieubrisse
mieubrisse approved these changes Feb 26, 2025
View reviewed changes
Copy link
Collaborator
@mieubrisse mieubrisse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some typos and a broader question about how commands are executed, but otherwise good

@tedim52 tedim52 force-pushed the tedi/acceptable-codes-fix branch from 1d717fe to 2132561 Compare February 26, 2025 17:43
@tedim52 tedim52 enabled auto-merge February 26, 2025 17:46
@tedim52 tedim52 added this pull request to the merge queue Feb 26, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Feb 26, 2025
@tedim52 tedim52 added this pull request to the merge queue Feb 26, 2025
@tedim52 tedim52 deleted the tedi/acceptable-codes-fix branch February 26, 2025 18:29
@kurtosisbot kurtosisbot mentioned this pull request Feb 26, 2025
Merged
github-merge-queue bot pushed a commit that referenced this pull request Mar 20, 2025
@kurtosisbot
chore(main): release 1.6.0 (#2655)
423c21e 
🤖 I have created a release *beep* *boop*
---


##
[1.6.0](1.5.0...1.6.0)
(2025-03-18)


### Features

* add resources to logs collector daemonset for k8s api server access
([#2663](#2663))
([5ae473c](5ae473c))
* export service logs (Docker)
([#2668](#2668))
([1651249](1651249))
* fluent bit logs collector in k8s backend
([#2653](#2653))
([05e3813](05e3813))
* vector logs aggregator in k8s
([#2669](#2669))
([106e4a2](106e4a2))


### Bug Fixes

* exit codes on tasks
([#2654](#2654))
([ffd86b8](ffd86b8))
* push ci docs
([#2680](#2680))
([61857f0](61857f0))
* stdout for file inspect
([#2658](#2658))
([6ae51a3](6ae51a3))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mieubrisse mieubrisse mieubrisse approved these changes

Assignees
No one assigned
4AE2
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tedim52 @mieubrisse
0