fix: logs for tasks #2499
Merged
fix: logs for tasks #2499
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tedim52
commented
Jun 21, 2024
core/server/api_container/server/startosis_engine/kurtosis_instruction/tasks/run_sh.go
Outdated
Show resolved
Hide resolved
h4ck3rk3y
approved these changes
Jun 24, 2024
|
The video I put in the description runs against the ethereum package. |
tedim52
commented
Jul 3, 2024
core/server/api_container/server/startosis_engine/kurtosis_instruction/tasks/tasks_shared.go
Show resolved
Hide resolved
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jul 3, 2024
🤖 I have created a release *beep* *boop* --- ## [1.0.0](0.90.1...1.0.0) (2024-07-03) ### ⚠ BREAKING CHANGES * release version 1 ([#2487](#2487)) ### Features * add maintainers ([#2502](#2502)) ([713e7dd](713e7dd)) * release version 1 ([#2487](#2487)) ([b9e2427](b9e2427)) ### Bug Fixes * Fix self hosting overview image ([#2500](#2500)) ([36065a8](36065a8)) * logs for tasks ([#2499](#2499)) ([e7ef915](e7ef915)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). --------- Co-authored-by: kurtosisbot <kurtosisbot@users.noreply.github.com>
github-merge-queue bot
pushed a commit
that referenced
this pull request
Feb 26, 2025
## Description ... and adds `acceptable_codes` and `skip_code_check` fields to `plan.run-sh` and `plan.run_python`, similar to `plan.exec` Exit codes on tasks were broken by this [change](#2499) - the exit code was from the last `echo` which was always 0 / success, meaning even if `commandToRun` failed, `run_sh` would return success. This fixes that issue by saving the exit code of the original `commandToRun` and exiting with that as the final step. TODO: - [X] update docs - [X] add some acceptable code tests - [X] remove reliance on bash if possible ## Is this change user facing? YES ## References #2499 Addresses #2649 and #2649
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR manipulates
run_shandrun_pythonlogic to stream logs from the command or python script thats being executed on the container. This also allows retrieving task logs after a run has finished, whereas before, task containers would not return logs fromkurtosis service logs.An improvement to this would be to enable streaming back logs via run output so users don't have to go through Docker Desktop or docker cli to view logs from a long running task that might have err'd.
https://www.loom.com/share/89181c37442048b9bdc746bfd37fe2ec
Is this change user facing?
YES