Allow users to turn the ExecprobeTimeout feature on or off #98085
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: carlory The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/assign @saad-ali |
|
/test pull-kubernetes-e2e-gce-ubuntu-containerd |
|
/cc @oomichi |
|
I think we also need to consider whether users would appreciate another release where they can keep the exec probe timeout disabled. From my perspective there's no rush to lock this gate to true so open to leave it around for another release if it helps users. cc @SergeyKanzhelev @derekwaynecarr @dchen1107 |
I agree that extra release would be beneficial. 1.20 is not yet available on GKE so we do not know how fast the timeouts will be updated. And I mostly worried about third-party payload or templates that may take some time to update, not customer apps. Extra 3-4 month would definitely help. |
cf7b193 to
3323d82
Compare
|
@oomichi @andrewsykim @SergeyKanzhelev thanks for your review. updated |
|
/test pull-kubernetes-e2e-gce-ubuntu-containerd |
|
@oomichi @andrewsykim @SergeyKanzhelev All tests passed |
| @@ -774,7 +774,7 @@ var defaultKubernetesFeatureGates = map[featuregate.Feature]featuregate.FeatureS | |||
| HPAContainerMetrics: {Default: false, PreRelease: featuregate.Alpha}, | |||
| RootCAConfigMap: {Default: true, PreRelease: featuregate.Beta}, | |||
| SizeMemoryBackedVolumes: {Default: false, PreRelease: featuregate.Alpha}, | |||
| ExecProbeTimeout: {Default: true, PreRelease: featuregate.GA}, // lock to default in v1.21 and remove in v1.22 | |||
| ExecProbeTimeout: {Default: true, PreRelease: featuregate.GA}, // remove in v1.22 | |||
There was a problem hiding this comment.
We have this still commented to remove in v1.22 but we should first lock it for a release before then. I think if we want to change how we're managing the release cycle for this feature we should update the KEP and bump the graduation timelines.
/hold
There was a problem hiding this comment.
Agreed we should get the KEP updated before we update this.
There was a problem hiding this comment.
There was a problem hiding this comment.
@carlory can you please update the comment so it will not say "1.22".
| ExecProbeTimeout: {Default: true, PreRelease: featuregate.GA}, // remove in v1.22 | |
| ExecProbeTimeout: {Default: true, PreRelease: featuregate.GA}, // lock to default and remove after v1.22 based on KEP #1972 update |
|
/kind cleanup |
|
KEP link: kubernetes/enhancements#1972 for cross reference |
|
@ehashman cancel the hold as Sergey has updated the KEP. |
|
/priority important-soon |
|
/close in favor of #100023, since there is no reply for a while |
|
@SergeyKanzhelev: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
What type of PR is this?
/kind bug
/kind cleanup
What this PR does / why we need it:
Allow users to turn this feature on or off in v1.21
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?:
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: