10000 Updated graduation criteria for ExecProbeTimeout removal by SergeyKanzhelev · Pull Request #2294 · kubernetes/enhancements · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated graduation criteria for ExecProbeTimeout removal #2294

Merged
merged 1 commit into from
Jan 26, 2021
Merged

Updated graduation criteria for ExecProbeTimeout removal #2294

merged 1 commit into from
Jan 26, 2021

Conversation

SergeyKanzhelev
Copy link
Member

A few fixes including an update for feature flag removal criteria for the kubernetes/kubernetes#98085

KEP: #1972
/sig node

@k8s-ci-robot k8s-ci-robot added sig/node Categorizes an issue or PR as relevant to SIG Node. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jan 19, 2021
@SergeyKanzhelev SergeyKanzhelev mentioned this pull request Jan 19, 2021
Closed
@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jan 19, 2021
@k8s-ci-robot k8s-ci-robot added the kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory label Jan 19, 2021
@SergeyKanzhelev SergeyKanzhelev force-pushed the execProbetimeOutSmallUpdates branch from 13edc70 to b77357a Compare January 19, 2021 23:34
@SergeyKanzhelev
Copy link
Member Author

/assign @dchen1107

@derekwaynecarr
Copy link
Member

This seems reasonable. I wonder if our docs could alert a user on where to provide a call to action if an extension is needed.

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 26, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: derekwaynecarr, SergeyKanzhelev

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 26, 2021
@k8s-ci-robot k8s-ci-robot merged commit a9072eb into kubernetes:master Jan 26, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.21 milestone Jan 26, 2021
@SergeyKanzhelev SergeyKanzhelev deleted the execProbetimeOutSmallUpdates branch January 26, 2021 18:17
@SergeyKanzhelev SergeyKanzhelev mentioned this pull request Mar 7, 2021
Closed
@carlory carlory mentioned this pull request Oct 11, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrewsykim andrewsykim andrewsykim left review comments

@dchen1107 dchen1107 Awaiting requested review from dchen1107

@derekwaynecarr derekwaynecarr Awaiting requested review from derekwaynecarr

Assignees

@derekwaynecarr derekwaynecarr

@dchen1107 dchen1107

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/node Categorizes an issue or PR as relevant to SIG Node. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
v1.21
Development

Successfully merging this pull request may close these issues.
5 participants
@SergeyKanzhelev @derekwaynecarr @k8s-ci-robot @andrewsykim @dchen1107
0