Bump dependencies in appraisals #287
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Looking into the integration specs they're currently copied into the Rails 'stub' application, loaded for the tests.
Sounds likely that it's only aware of smt like |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Synchronize with parent Gemfile.
Would be good to automate these; will need to recall why I didn't ask dependabot to update these at the same time as the parent (possibly it didn't detect them due to the file names?)
Alternative would to not commit the lockfiles and generate them at runtime from parent, or not use them at all as they are not being run in deployment mode anyway (I think due to some issues with ruby 2.6 compat on JRuby 9.3 that needs to install a different version)