cleanup support for Rails 2.3 and remove old integration tests #280
Conversation
|
I must admit that I didn’t understand this stuff, however I wondered whether rather than deleting it, it needed to be adapted to rails 6.1 and 7.x to actually run specific rails tests there - which is why I didn’t delete them earlier. There seemed to be some magic there that looked for these specs if they existed for a given rails version and run them. I somehow had the impression that there were not real tests being run via the appraisals for later versions without such version specific dirs. But yes, these are definitely unused right now. |
As long as we're talking about the Rails booter specs then than would depend on whether there's changes to the stuff we're adding/overriding. There's 2 groups (similar to the removed 2.3 group) left here:
The idea around
The integration spec mostly has those and there the removed group having |
|
Now having a second look, you're right. We should have some Rails skeleteon under src/spec/stub based on actual Rails version and use those as a (smoke) "integration" test. And I should also do more cleanup here, since I obviously missed a lot 😜. |
|
Managed to remove the Rails stub apps, and also looked into adding back (in a follow-up PR) some based on the Rails versions currently supported. I have a 7.2 passing tests locally and will setup another one likely for Rails 6.1 ( |
mostly just removing unused code/specs