8000 React Resizable Panels Theme by ImmanuelBaskaran · Pull Request #5053 · jpmorganchase/salt-ds · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

React Resizable Panels Theme #5053

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 33 commits into from
May 16, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
33 commits
Select commit Hold shift + click to select a range
ed51ed3
feat(splitter): implement css theme for react-resizable-panels
ImmanuelBaskaran Apr 28, 2025
acce73b
feat(splitter): create build scripts for splitter theme
ImmanuelBaskaran Apr 29, 2025
8402db4
feat(splitter): use classes for border and variants
ImmanuelBaskaran Apr 30, 2025
8948aaa
feat(splitter): use classes on Panel components for variants
ImmanuelBaskaran Apr 30, 2025
cfebe9a
feat(splitter): use classes on Panel components for variants
ImmanuelBaskaran Apr 30, 2025
821f4fe
feat(splitter): use classes on Panel components for variants
ImmanuelBaskaran Apr 30, 2025
a16b283
feat(splitter): documentation
ImmanuelBaskaran May 2, 2025
00fd9e6
feat(splitter): refactoring styles and documentation
ImmanuelBaskaran May 2, 2025
51a5a3f
feat(splitter): add release candidate label to docs
ImmanuelBaskaran May 2, 2025
49a4a2d
fix(splitter): build scripts
ImmanuelBaskaran May 2, 2025
34c7597
fix(splitter): linting errors
ImmanuelBaskaran May 2, 2025
19d2147
fix(splitter): prettier errors
ImmanuelBaskaran May 2, 2025
4fdacb5
fix(splitter): build command
ImmanuelBaskaran May 2, 2025
62a962d
docs(splitter): update docs
ImmanuelBaskaran May 6, 2025
a9d216d
docs(splitter): only inject react-resizable-panels-theme when viewing…
ImmanuelBaskaran May 6, 2025
9c846ec
feat(splitter): addressed feedback
ImmanuelBaskaran May 6, 2025
a9ca887
feat(splitter): addressed feedback
ImmanuelBaskaran May 6, 2025
54ddeb8
feat(splitter): scope theme to classname react-resizable-panels-theme…
ImmanuelBaskaran May 7, 2025
41c58cc
feat(splitter): scope theme to classname react-resizable-panels-theme…
ImmanuelBaskaran May 7, 2025
bd2a881
feat(splitter): scope theme to classname react-resizable-panels-theme…
ImmanuelBaskaran May 7, 2025
df73e94
feat(splitter): update changeset
ImmanuelBaskaran May 7, 2025
bbe3228
feat(splitter): QA examples
ImmanuelBaskaran May 8, 2025
aa9b2ab
feat(splitter): linting fixes
ImmanuelBaskaran May 9, 2025
506d7a0
feat(splitter): addressed feedback
ImmanuelBaskaran May 14, 2025
d56ad75
feat(splitter): made single border resize handles 6px
ImmanuelBaskaran May 14, 2025
376df26
feat(splitter): fix issue where splitter thumb is positioned incorrec…
ImmanuelBaskaran May 14, 2025
8e1e5a9
feat(splitter): addressed feedback
ImmanuelBaskaran May 15, 2025
0a50fe3
feat(splitter): add alsoKnownAs
ImmanuelBaskaran May 15, 2025
a753a41
feat(splitter): add alsoKnownAs
ImmanuelBaskaran May 15, 2025
f32560b
feat(splitter): rename page to splitter
ImmanuelBaskaran May 15, 2025
8cbbdf0
feat(splitter): fix error in documentation
ImmanuelBaskaran May 15, 2025
e791ff6
- swapped `rotate` CSS for minimum browser compliant transform.
mark-tate May 15, 2025
7a6a6e6
- Update site title
origami-z May 16, 2025
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/cold-glasses-develop.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@salt-ds/lab": minor
---

- Removed `Splitter` component from labs, replaced with `@salt-ds/react-resizable-panels-theme` package.
33 changes: 33 additions & 0 deletions .changeset/good-frogs-drop.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,33 @@
---
"@salt-ds/react-resizable-panels-theme": major
---

Created the `@salt-ds/react-resizable-panels-theme` package.

To install the `@salt-ds/react-resizable-panels-theme` package, run the command appropriate to your environment: `yarn add @salt-ds/react-resizable-panels-theme` or `npm install @salt-ds/react-resizable-panels-theme`

To import the Salt React Resizable Panels theme, use:

```js
import "@salt-ds/react-resizable-panels-theme/index.css";
```

Then wrap your React Resizable Panel Group with the `react-resizable-panels-theme-salt` class name:

```js
<div className="react-resizable-panels-theme-salt">
<PanelGroup direction="horizontal">
<Panel id="left">
<Text>Left</Text>
</Panel>
<PanelResizeHandle />
<Panel id="middle">
<Text>Center</Text>
</Panel>
<PanelResizeHandle />
<Panel id="right">
<Text>Right</Text>
</Panel>
</PanelGroup>
</div>
```
1 change: 1 addition & 0 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -95,6 +95,7 @@
"react": "^18.3.1",
"react-docgen-typescript": "2.2.2",
"react-dom": "^18.3.1",
"react-resizable-panels": "^3.0.0",
"rifm": "^0.12.0",
"storybook": "^8.4.4",
"stylelint": "^16.0.0",
Expand Down
1 change: 0 additions & 1 deletion packages/lab/package.json
< 1041D td class="blob-code blob-code-context js-file-line"> "react-color": "^2.19.3",
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,6 @@
"deepmerge": "^4.2.2",
"no-scroll": "^2.1.1",
"react-resizable-panels": "^2.1.7",
"react-window": "^1.8.6",
"rifm": "^0.12.0",
"tabbable": "^6.0.0",
Expand Down
62 changes: 0 additions & 62 deletions packages/lab/src/__tests__/__e2e__/splitter/Splitter.cy.tsx

This file was deleted.

1 change: 0 additions & 1 deletion packages/lab/src/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,6 @@ export * from "./portal";
export * from "./query-input";
export * from "./responsive";
export * from "./search-input";
export * from "./splitter";
export * from "./static-list";
export * from "./system-status";
export * from "./tabs";
Expand Down
199 changes: 0 additions & 199 deletions packages/lab/src/splitter/SplitHandle.css

This file was deleted.

Loading
Loading
0