8000 React Resizable Panels Theme by ImmanuelBaskaran · Pull Request #5053 · jpmorganchase/salt-ds · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

React Resizable Panels Theme #5053

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 33 commits into from
May 16, 2025
Merged

React Resizable Panels Theme #5053

merged 33 commits into from
May 16, 2025

Conversation

ImmanuelBaskaran
Copy link
Contributor

No description provided.

Copy link
changeset-bot bot commented May 2, 2025

🦋 Changeset detected

Latest commit: 7a6a6e6

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@salt-ds/lab Minor
@salt-ds/react-resizable-panels-theme Major
@salt-ds/data-grid Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
vercel bot commented May 2, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
saltdesignsystem ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 16, 2025 9:00am

@ImmanuelBaskaran
Copy link
Contributor 8000 Author

/release-pr

Copy link
Contributor
github-actions bot commented May 2, 2025

🫰✨ Thanks @ImmanuelBaskaran! Your snapshot has been published to npm.

Test the snapshot by updating your package.json with the newly published version:

yarn add @salt-ds/react-resizable-panels-theme@0.0.0

@ImmanuelBaskaran ImmanuelBaskaran marked this pull request as ready for review May 6, 2025 12:48
@ImmanuelBaskaran ImmanuelBaskaran added the chromatic Run chromatic on the current PR. Will be removed by the CI once submitted. label May 6, 2025
@github-actions github-actions bot removed the chromatic Run chromatic on the current PR. Will be removed by the CI once submitted. label May 6, 2025
@ImmanuelBaskaran ImmanuelBaskaran added the chromatic Run chromatic on the current PR. Will be removed by the CI once submitted. label May 7, 2025
@github-actions github-actions bot removed the chromatic Run chromatic on the current PR. Will be removed by the CI once submitted. label May 7, 2025
@ImmanuelBaskaran
Copy link
Contributor Author

/release-pr

Copy link
Contributor
github-actions bot commented May 7, 2025

🫰✨ Thanks @ImmanuelBaskaran! Your snapshots have been published to npm.

Test the snapshots by updating your package.json with the newly published versions:

yarn add @salt-ds/data-grid@0.0.0-snapshot-20250507110136
yarn add @salt-ds/lab@0.0.0-snapshot-20250507110136
yarn add @salt-ds/react-resizable-panels-theme@0.0.0-snapshot-20250507110136

@ImmanuelBaskaran ImmanuelBaskaran requested a review from origami-z May 7, 2025 11:47
@origami-z
Copy link
Contributor

Add some chromatic QA checks, and ask for design review

@mark-tate mark-tate force-pushed the react-resizable-panels-theme branch from 10f2d1f to e791ff6 Compare May 15, 2025 23:25
mark-tate
mark-tate previously approved these changes May 15, 2025
Copy link
Contributor
@origami-z origami-z left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to fix version 2.1.7, otherwise mergable

- Fix QA not captured, combine to 1 story
- Fix pgk version to be 3.0.0
@origami-z origami-z added the chromatic Run chromatic on the current PR. Will be removed by the CI once submitted. label May 16, 2025
@github-actions github-actions bot removed the chromatic Run chromatic on the current PR. Will be removed by the CI once submitted. label May 16, 2025
@origami-z origami-z merged commit 4a240fd into main May 16, 2025
15 checks passed
@origami-z origami-z deleted the react-resizable-panels-theme branch May 16, 2025 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Splitter - Promote To Core
4 participants
0