Fix installJoomlaMultilingualSite #29
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update README overview commands (joomla-projects#20)
merge from head repository
Added skip tour (joomla-projects#27)
When the files are deleted, the web server sometimes still delivers content and does not fail as expected with 404 - Not Found. In such cases, we try again one second later for 10 retries.
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Finally, the custom command
installJoomlaMultilingualSitedeletes theinstallationfolder. It is checked whether this was successful with 404 - Not Found.But there are two problems:
Forbidden - You don't have permission to access this ressource.For such cases it needs to check the response status and not the page content.This PR implements that it is tried again one second later, for 10 retries.
Additional
Tests
This PR was extensively tested based on joomla-cpress 1.1.0 together with #28 on:
👉 The custom command
installJoomlaMultilingualSiteis actual not used in Joomla System Tests.