8000 Fixing and improving createMenuItem by muhme · Pull Request #28 · joomla-projects/joomla-cypress · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Fixing and improving createMenuItem #28

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Aug 7, 2024
Merged

Fixing and improving createMenuItem #28

merged 10 commits into from
Aug 7, 2024

Conversation

muhme
Copy link
Contributor
@muhme muhme commented Jul 27, 2024 •
edited
Loading

Problems found while documenting and testing the functionality:

  1. The custom command createMenuItem, working in Joomla 4, fails in Joomla 5 with:
AssertionError: Timed out retrying after 4000ms: Expected to find element: `.controls > .input-group > .btn`, but never found it.
  1. The language setting was not implemented

This PR makes createMenuItem

  • Working for the default and all active Joomla branches and
  • Implements setting the language.

Additional

  • Improving method comment (PR will follow for all methods)
  • Directly defining the function
  • Standardisation of the coding style by omitting single semicolons

Tests

This PR is extensively tested with test.cy.js based on joomla-cpress 1.1.0 plus #29:

  • Intel macOS 14.5 Sonoma native with Joomla 4.4-dev
  • Intel macOS 14.5 Sonoma docker-based with Joomla 4.4-dev, 5.1-dev, 5.2-dev and 6.0-dev
  • Windows 11 Pro Laragon with Joomla 5.1-dev
  • Windows 11 Pro WSL 2 docker-based with Joomla 4.4-dev, 5.1-dev, 5.2-dev and 6.0-dev

Sample test output:

  Running:  test.cy.js                                                                      (1 of 1)
  Test createMenuItem
    ✓ have fresh start with installJoomla (23138ms)
    ✓ can create with minimum arguments - 1st (4877ms)
    ✓ can create with explicit set menu and (unused) language - 2nd (4660ms)
    ✓ can create in different menu - 3rd (5762ms)
    ✓ change to multilingual website and install second language ja-JP (10877ms)
    ✓ still can create with minimum arguments - 4th (5467ms)
    ✓ can create with explicit set menu and using language ja-JP - 第5 (4698ms)
    ✓ can create with third language uk-UA - 6-й (13427ms)

Created menu items are:
menu-items

👉 This custom command is actual not used in Joomla System Tests.

muhme added 6 commits June 19, 2024 09:58
@muhme
Merge pull request #1 from joomla-projects/main
16b0570 
Update README overview commands (joomla-projects#20)
@muhme
Merge pull request #2 from joomla-projects/main
959039b 
merge from head repository
@muhme
Fix createMenuItem
859ea05 
- Make it working for Joomla >= 5
- Implement language selection
- Refactor method documentation and unify non-use of the semicolon
@muhme
Pollish method documentation
afc0dc3
@muhme
Working on Joomla 4
4402741
@muhme
Merge pull request #3 from joomla-projects/main
f9d77a5 
Added skip tour (joomla-projects#27)
@muhme muhme mentioned this pull request Jul 27, 2024
Merged
laoneo
laoneo reviewed Aug 6, 2024
View reviewed changes
@laoneo laoneo merged commit 1eb6f7f into joomla-projects:main Aug 7, 2024
@laoneo
Copy link
Contributor
laoneo commented Aug 7, 2024

Thanks!

@muhme muhme deleted the fix-createMenuItem branch August 7, 2024 08:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@laoneo laoneo laoneo left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@muhme @laoneo
0