8000 ci: skip code injection for forks by deepankarm · Pull Request #3494 · jina-ai/serve · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

ci: skip code injection for forks #3494

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 28, 2021
Merged

ci: skip code injection for forks #3494

merged 1 commit into from
Sep 28, 2021

Conversation

deepankarm
Copy link
Contributor

This PR skips the complete step for code-injection and would unblock #3448.

There's still an issue with this step. Whenever there's a commit added by jina-dev-bot the CI run gets stuck. It starts again onlly if the PR is reopened.

@deepankarm deepankarm requested a review from hanxiao as a code owner September 27, 2021 16:31
@github-actions github-actions bot added size/XS area/cicd This issue/PR affects the cicd pipeline area/housekeeping This issue/PR is housekeeping labels Sep 27, 2021
@codecov
Copy link
codecov bot commented Sep 27, 2021 •
edited
Loading

Codecov Report

Merging #3494 (afd81d5) into master (e9d9a43) will increase coverage by 0.06%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3494      +/-   ##
==========================================
+ Coverage   90.08%   90.14%   +0.06%     
==========================================
  Files         151      151              
  Lines       11070    11070              
==========================================
+ Hits         9972     9979       +7     
+ Misses       1098     1091       -7
Flag Coverage Δ
daemon 45.77% <100.00%> (ø)
jina 90.08% <100.00%> (+0.06%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
jina/__init__.py 71.25% <100.00%> (ø)
jina/helper.py 83.12% <0.00%> (+0.35%) ⬆️
jina/peapods/runtimes/zmq/zed.py 93.87% <0.00%> (+0.51%) ⬆️
jina/peapods/runtimes/gateway/prefetch.py 95.06% <0.00%> (+1.23%) ⬆️
jina/clients/base/grpc.py 70.21% <0.00%> (+6.38%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 51ffcd5...afd81d5. Read the comment docs.

@github-actions
Copy link

Latency summary

Current PR yields:

  • 🐢🐢 index QPS at 1045, delta to last 2 avg.: -17%
  • 🐢🐢 query QPS at 43, delta to last 2 avg.: -18%
  • 🐢🐢 dam extend QPS at 39867, delta to last 2 avg.: -21%
  • 🐢🐢 avg flow time within 1.7493 seconds, delta to last 2 avg.: +26%
  • 🐎🐎🐎🐎 import jina within 0.4461 seconds, delta to last 2 avg.: +16%

Breakdown

Version Index QPS Query QPS DAM Extend QPS Avg Flow Time (s) Import Time (s)
current 1045 43 39867 1.7493 0.4461
2.1.4 1430 60 58939 1.0627 0.3397
2.1.3 1099 45 42508 1.6982 0.4233

Backed by latency-tracking. Further commits will update this comment.

@hanxiao hanxiao merged commit 36b1eb5 into master Sep 28, 2021
@hanxiao hanxiao deleted the skip-code-injection-fork branch September 28, 2021 05:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JoanFM JoanFM JoanFM approved these changes

@hanxiao hanxiao Awaiting requested review from hanxiao

Assignees
No one assigned
Labels
area/cicd This issue/PR affects the cicd pipeline area/housekeeping This issue/PR is housekeeping size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@deepankarm @JoanFM @hanxiao
0