feat: add parser to jina hub new #3448

sauravgarg540 · 2021-09-20T18:55:40Z

This PR aims at resolving #3393.

Resolution:

A new.py file is added to add a parser to Jina hub new.
added arguments in test_new of test_hubio.py
Updated hubio.py to make use of command-line arguments.

jina/parsers/hubble/new.py

hanxiao

need style fix
need unit test

sauravgarg540 · 2021-09-25T14:24:13Z

Hey @hanxiao, I have made the changes as suggested by you. Waiting for your feedback.

JoanFM · 2021-09-26T16:52:10Z

/recheckcla

bwanglzu · 2021-09-27T12:57:27Z

interesting, latency tracking seems added 2 times to ci:

JoanFM

Tests are skipped, we have to check why

codecov · 2021-09-28T10:32:10Z

Codecov Report

Merging #3448 (e4dc8f9) into master (cb46192) will decrease coverage by 0.61%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #3448      +/-   ##
==========================================
- Coverage   90.28%   89.67%   -0.62%     
==========================================
  Files         152      152              
  Lines       11019    11260     +241     
==========================================
+ Hits         9949    10097     +148     
- Misses       1070     1163      +93

Flag	Coverage Δ
daemon	`45.57% <77.27%> (-0.05%)`	⬇️
jina	`89.60% <100.00%> (-0.68%)`	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
jina/hubble/hubio.py	`87.50% <100.00%> (-0.28%)`	⬇️
jina/parsers/hubble/__init__.py	`96.87% <100.00%> (+0.72%)`	⬆️
jina/parsers/hubble/new.py	`100.00% <100.00%> (ø)`
jina/peapods/networking.py	`58.88% <0.00%> (-41.12%)`	⬇️
jina/types/arrays/document.py	`85.38% <0.00%> (-3.02%)`	⬇️
jina/peapods/runtimes/zmq/asyncio.py	`90.32% <0.00%> (-2.66%)`	⬇️
jina/types/arrays/bpm.py	`98.18% <0.00%> (-1.82%)`	⬇️ 8000
jina/types/arrays/neural_ops.py	`87.90% <0.00%> (-1.36%)`	⬇️
jina/peapods/grpc/__init__.py	`90.00% <0.00%> (-1.21%)`	⬇️
jina/types/document/generators.py	`92.20% <0.00%> (-1.13%)`	⬇️
... and 28 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cb46192...e4dc8f9. Read the comment docs.

JoanFM

Thank you very much for this great contribution!

feat: add parser to jina hub new

f8b987a

sauravgarg540 requested a review from a team as a code owner September 20, 2021 18:55

sauravgarg540 requested review from CatStark and BastinJafari September 20, 2021 18:55