8000 refactor: simplify event loop usage by JoanFM · Pull Request #4811 · jina-ai/serve · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

refactor: simplify event loop usage #4811

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 20, 2022
Merged

refactor: simplify event loop usage #4811

merged 1 commit into from
May 20, 2022

Conversation

JoanFM
Copy link
Contributor
@JoanFM JoanFM commented May 20, 2022

Goals:

  • ...
  • ...
  • check and update documentation. See guide and ask the team.

@github-actions github-actions bot added size/S area/core This issue/PR affects the core codebase area/helper This issue/PR affects the helper functionality component/client labels May 20, 2022
@codecov
Copy link
codecov bot commented May 20, 2022 •
edited
Loading

Codecov Report

Merging #4811 (6185ef9) into master (a9ed27e) will increase coverage by 1.29%.
The diff coverage is 66.66%.

@@            Coverage Diff             @@
##           master    #4811      +/-   ##
==========================================
+ Coverage   86.92%   88.21%   +1.29%     
==========================================
  Files         119      119              
  Lines        9031     9030       -1     
==========================================
+ Hits         7850     7966     +116     
+ Misses       1181     1064     -117
Flag Coverage Δ
jina 88.21% <66.66%> (+1.37%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
jina/helper.py 81.12% <50.00%> (+0.12%) ⬆️
jina/clients/base/websocket.py 93.05% <100.00%> (ø)
jina/serve/networking.py 88.80% <0.00%> (+0.25%) ⬆️
jina/jaml/__init__.py 94.79% <0.00%> (+0.37%) ⬆️
jina/orchestrate/deployments/config/k8s.py 100.00% <0.00%> (+0.64%) ⬆️
jina/serve/runtimes/gateway/http/app.py 92.53% <0.00%> (+0.74%) ⬆️
jina/enums.py 88.07% <0.00%> (+0.91%) ⬆️
jina/clients/mixin.py 93.18% <0.00%> (+1.13%) ⬆️
jina/clients/base/http.py 95.31% <0.00%> (+1.56%) ⬆️
... and 11 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a9ed27e...6185ef9. Read the comment docs.

@github-actions
Copy link

Latency summary

Current PR yields:

  • 😶 index QPS at 1338, delta to last 2 avg.: +5%
  • 🐎🐎🐎🐎 query QPS at 79, delta to last 2 avg.: +12%
  • 🐎🐎🐎🐎 avg flow time within 1.6318 seconds, delta to last 2 avg.: +26%
  • 🐢🐢 import jina within 0.4668 seconds, delta to last 2 avg.: -8%

Breakdown

Version Index QPS Query QPS Avg Flow Time (s) Import Time (s)
current 1338 79 1.6318 0.4668
3.4.4 1379 75 1.2453 0.4594
3.4.3 1155 64 1.3259 0.5558

Backed by latency-tracking. Further commits will update this comment.

@JoanFM JoanFM marked this pull request as ready for review May 20, 2022 10:10
@JoanFM JoanFM requested a review from deepankarm May 20, 2022 10:10
@JoanFM JoanFM merged commit 93f06fc into master May 20, 2022
@JoanFM JoanFM deleted the trial-asyncio-simplify branch May 20, 2022 12:59
@JoanFM JoanFM mentioned this pull request May 21, 2022
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deepankarm deepankarm deepankarm approved these changes

Assignees
No one assigned
Labels
area/core This issue/PR affects the core codebase area/helper This issue/PR affects the helper functionality component/client size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JoanFM @deepankarm
0