8000 fix: avoid closing loop at fork time by JoanFM · Pull Request #4803 · jina-ai/serve · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix: avoid closing loop at fork time #4803

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
May 21, 2022
Merged

fix: avoid closing loop at fork time #4803

merged 9 commits into from
May 21, 2022

Conversation

JoanFM
Copy link
Contributor
@JoanFM JoanFM commented May 18, 2022

Goals:

  • ...
  • ...
  • check and update documentation. See guide and ask the team.

@JoanFM JoanFM linked an issue May 18, 2022 that may be closed by this pull request
Run 2 flows one after the other will get stuck in waiting pods ready #4792
Closed
@github-actions github-actions bot added size/XS area/core This issue/PR affects the core codebase area/helper This issue/PR affects the helper functionality labels May 18, 2022
@github-actions
Copy link
github-actions bot commented May 18, 2022 •
edited
Loading

Latency summary

Current PR yields:

  • 😶 index QPS at 1310, delta to last 2 avg.: -3%
  • 😶 query QPS at 73, delta to last 2 avg.: +0%
  • 😶 avg flow time within 1.3358 seconds, delta to last 2 avg.: -2%
  • 🐎🐎 import jina within 0.4878 seconds, delta to last 2 avg.: +6%

Breakdown

Version Index QPS Query QPS Avg Flow Time (s) Import Time (s)
current 1310 73 1.3358 0.4878
3.4.4 1352 72 1.5199 0.4561
3.4.3 1373 72 1.2159 0.4557

Backed by latency-tracking. Further commits will update this comment.

@codecov
Copy link
codecov bot commented May 18, 2022 •
edited
Loading

Codecov Report

Merging #4803 (e299fc6) into master (93f06fc) will decrease coverage by 0.05%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #4803      +/-   ##
==========================================
- Coverage   88.31%   88.25%   -0.06%     
==========================================
  Files         119      119              
  Lines        9034     9024      -10     
==========================================
- Hits         7978     7964      -14     
- Misses       1056     1060       +4
Flag Coverage Δ
jina 88.25% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
jina/helper.py 81.32% <ø> (+0.19%) ⬆️
jina/serve/runtimes/gateway/http/app.py 92.48% <100.00%> (-0.06%) ⬇️
jina/serve/runtimes/gateway/http/__init__.py 97.77% <0.00%> (-2.23%) ⬇️
...a/orchestrate/deployments/config/docker_compose.py 99.00% <0.00%> (-1.00%) ⬇️
jina/orchestrate/flow/base.py 89.56% <0.00%> (-0.58%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 93f06fc...e299fc6. Read the comment docs.

@JoanFM JoanFM marked this pull request as draft May 18, 2022 14:55
@github-actions github-actions bot added size/S area/testing This issue/PR affects testing labels May 19, 2022
@JoanFM JoanFM force-pushed the fix-close-loop-at-fork branch from 3a555f6 to cc4b77e Compare May 19, 2022 14:23
@JoanFM JoanFM changed the title fix: close loop only if running fix: close loop only if not on mac May 19, 2022
@JoanFM JoanFM changed the title fix: close loop only if not on mac fix: avoid closing loop at fork time May 21, 2022
@JoanFM
Copy link
Contributor Author
JoanFM commented May 21, 2022

In combination with #4811 makes it unnecessary

@JoanFM JoanFM marked this pull request as ready for review May 21, 2022 18:57
@JoanFM JoanFM merged commit a2bc230 into master May 21, 2022
@JoanFM JoanFM deleted the fix-close-loop-at-fork branch May 21, 2022 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
area/core This issue/PR affects the core codebase area/helper This issue/PR affects the helper functionality area/testing This issue/PR affects testing size/M size/S size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Run 2 flows one after the other will get stuck in waiting pods ready
1 participant
@JoanFM
0