10000 SyntheticFilter should filter out only synthetic accessors in Kotlin classes by Godin · Pull Request #1700 · jacoco/jacoco · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

SyntheticFilter should filter out only synthetic accessors in Kotlin classes #1700

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Sep 10, 2024
Merged

SyntheticFilter should filter out only synthetic accessors in Kotlin classes #1700

merged 6 commits into from
Sep 10, 2024

Conversation

Godin
Copy link
Member
@Godin Godin commented Sep 6, 2024 •
edited
Loading

Fixes #1669
Fixes #1696

@Godin Godin added this to the 0.8.13 milestone Sep 6, 2024
@Godin Godin self-assigned this Sep 6, 2024
@Godin Godin marked this pull request as ready for review September 9, 2024 14:03
@Godin Godin requested a review from leveretka September 9, 2024 14:03
@Godin
Copy link
Member Author
Godin commented Sep 10, 2024

Similarly to #1670 (comment)

I looked at some popular open-source projects, and the results matched expectations and our validation tests.
To find differences in reports I used XML diff written some time ago - #811
And was not able to find any unexpected differences.

For example for https://github.com/detekt/detekt

before this change

before

after this change

after

leveretka
leveretka approved these changes Sep 10, 2024
View reviewed changes
Copy link
Collaborator
@leveretka leveretka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Nice work!

@Godin Godin merged commit 58b3e65 into jacoco:master Sep 10, 2024
33 checks passed
@Godin Godin deleted the kotlin_synthetic branch September 10, 2024 20:50
@Godin Godin mentioned this pull request Apr 3, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leveretka leveretka leveretka approved these changes

Assignees

@Godin Godin

Labels
component: core.filters language: Kotlin
Projects
Filtering
Status: Done
Milestone
0.8.13
Development

Successfully merging this pull request may close these issues.

Kotlin @JvmSynthetic functions should not be filtered out Kotlin functions with reified type parameters should not be filtered out
2 participants
@Godin @leveretka
0