8000 Add internal tool that shows difference between two JaCoCo XML reports by Godin · Pull Request #811 · jacoco/jacoco · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Add internal tool that shows difference between two JaCoCo XML reports #811

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add internal tool that shows difference between two JaCoCo XML reports #811

wants to merge 1 commit into from

Conversation

Godin
Copy link
Member
@Godin Godin commented Dec 28, 2018

I used this little utility to check changes in filters on a real projects. And would like to add it as an example.

@Godin Godin added this to the 0.8.3 milestone Dec 28, 2018
@Godin Godin self-assigned this Dec 28, 2018
@Godin Godin requested a review from marchof December 28, 2018 17:42
@marchof
Copy link
Member
marchof commented Dec 29, 2018

@Godin I'm not sure whether this more like a tool than a educational example about our API usage. Have you considered adding this to the CLI instead?

@Godin
Copy link
Member Author
Godin commented Dec 29, 2018

@marchof I thought about this option - as it is now, it fits well into examples, because

  • we don't have example that works with XML, whereas I believe that this is the better path for third-party integrations than processing of exec-file
  • inclusion into CLI will require more hardening

marchof
marchof requested changes Jan 8, 2019
View reviewed changes
org.jacoco.examples/src/org/jacoco/examples/XMLDiff.java
public InputSource resolveEntity(final String publicId,
final String systemId) {
if (publicId.startsWith("-//JACOCO//DTD Report")) {
return new InputSource(new StringReader(""));
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is an example and should follow best practices:

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@marchof

Supply actual DTD otherwise this will fail when we merge #813

I probably miss something, but don't understand why/how absence of DTD can cause failure after merge of #813 ?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describ 8000 e this comment to others. Learn more.

Sorry, my bad: I overlooked that parseAsOptionalInt() already checks for null values.

@Godin Godin force-pushed the xml_diff branch 2 times, most recently from c97aecf to dbd5f99 Compare January 10, 2019 02:45
@Godin Godin changed the title Add example that shows difference between two JaCoCo XML reports Add internal tool that shows difference between two JaCoCo XML reports Jan 16, 2019
@Godin Godin removed this from the 0.8.3 milestone Jan 19, 2019
@Godin Godin added this to the 0.8.4 milestone Jan 22, 2019
@Godin Godin removed this from the 0.8.4 milestone May 8, 2019
@Godin Godin mentioned this pull request Aug 29, 2024
Merged
@Godin Godin mentioned this pull request Sep 10, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marchof marchof marchof requested changes

Requested changes must be addressed to merge this pull request.

Assignees

@Godin Godin

Labels
type: experimental 🚧
Projects
Current work items
Status: Candidates
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Godin @marchof
0