-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
Crash in VideoView.requestEdrMode while quitting #4328
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
This commit will: - Add a new isStopping property to PlayerCore - Change PlayerCore.trackListChanged to do nothing if the player is stopping or shutting down - Change PlayerCore.refreshEdrMode to do nothing if the player is stopping or shutting down
This commit will: - Add a new isStopping property to PlayerCore - Change PlayerCore.trackListChanged to do nothing if the player is stopping or shutting down - Change PlayerCore.refreshEdrMode to do nothing if the player is stopping or shutting down
The fix for this issue has been merged into the IINA Should you wish to confirm the fix is working and do not have the ability to build IINA from the sources in the The ability to disable this GitHub automatic closing action has been requested by GitHub users (discussions #23476 and #17308 for example), but so far GitHub has not implemented a way to control this behavior. |
IINA 1.3.2 contains the fix for this issue. |
System and IINA version:
Expected behavior:
IINA shuts down cleanly.
Actual behavior:
Very rarely while quitting IINA will crash in
mpv_get_property_string
, called fromVideoView.requestEdrMode
.Crash report:
Steps to reproduce:
Start IINA playing a HDR video, quit IINA, repeat until this reproduces.
This is an IINA problem.
How often does this happen?
This crash is very rare and very difficult to reproduce, at least that is the behavior on my Mac. This crash is timing related and may be easier to reproduce on other types of Macs.
The text was updated successfully, but these errors were encountered: