[Feature Request] Prevent issues from being closed by merging linked PRs #23476
-
|
I really like how the linked PRs in an issue are listed nicely on the project board as well as in the right side of the issue. It really makes discovering PRs from issues easy. In my current project, we don’t close issues until they reach production. Also, often we have multiple PRs which fix an issues (in multiple repositories). In such cases I do not want the issue to be autmatically closed, currently I just re-open them. This is not ideal because I could forget to re-open the issue and also this workflow causes a lot of notification noise in my team. It would be nice if this could somehow be configured, or if there was another keyword (instaed of fixes, closes, etc.) to signify that a PR only partially fixes an issue and the issue and the issue must not be closed auotmatically even after the PR is merged. |
Beta Was this translation helpful? Give feedback.
Replies: 90 comments 30 replies
-
|
Hi @akshaymankar, Thanks for this feedback! We’re always working to improve GitHub, and we consider every suggestion we receive. I’ve located an existing “feature request” for disabling the auto-close issues feature and added your voice to it. Though I can’t guarantee anything or share a timeline for this, I can tell you that it’s been shared with the appropriate teams for consideration. |
Beta Was this translation helpful? Give feedback.
-
|
4 years later ... STILL AN ISSUE 🔥 |
Beta Was this translation helpful? Give feedback.
-
|
any update? 😢 |
Beta Was this translation helpful? Give feedback.
-
|
This issue is closed!! Github will not pay any attention to this. Move over to this follow-up: https://github.com/orgs/community/discussions/66741 |
Beta Was this translation helpful? Give feedback.
-
|
Just FYI there's another duplicate in 2022 #17308. Filed later but with a lower number; go figure. |
Beta Was this translation helpful? Give feedback.
-
|
@AndreaGriffiths11 is this still being worked on? |
Beta Was this translation helpful? Give feedback.
-
|
Was this solved? I’ve the same problem and I would like to know if this feature request was applied or where can I see this feature request. |
Beta Was this translation helpful? Give feedback.
-
|
I really expect this feature as it is one primary use case where developer fix has to be verified by QA |
Beta Was this translation helpful? Give feedback.
-
|
Indeed |
Beta Was this translation helpful? Give feedback.
-
|
QA what? /s |
Beta Was this translation helpful? Give feedback.
-
|
This should be made with another keyword like for instance ‘Linked to #123’ |
Beta Was this translation helpful? Give feedback.
-
|
You can link issues without using an auto-close keyword. Just use I guess technically you won’t see them in that little “Linked issues” area in the PRs but you’ll still see the reference in the PR message and in the Issue history/log. |
Beta Was this translation helpful? Give feedback.
-
|
Can you provide a link to the existing feature request? Thanks. |
Beta Was this translation helpful? Give feedback.
-
|
Or at least a reference number. |
Beta Was this translation helpful? Give feedback.
-
|
Not using a github keyword such as |
Beta Was this translation helpful? Give feedback.
-
|
Agree, issues should never be closed before a release, since the issue still exist in the latest release, and it can take a long time before a new release with the fix applied is made. |
Beta Was this translation helpful? Give feedback.
-
|
Has there been any progress on this issue? |
Beta Was this translation helpful? Give feedback.
-
|
@AndreaGriffiths11 |
Beta Was this translation helpful? Give feedback.
-
|
any news here? I really like how Kanban shows the linked PRs. But we can use this as it closes the issue |
Beta Was this translation helpful? Give feedback.
-
|
Hello! We have kind of similar issue. In our case it’s ok for issues to be closed when there is ONLY one PR. However, when having multiple linked PR’s, we expect the issue to be closed when the last open PR is merged. Thanks github team for your effort on continuous improvement! |
Beta Was this translation helpful? Give feedback.
-
|
We need an ability to auto-close most issues and then not to auto-close others. So, a separate keyword similar to |
Beta Was this translation helpful? Give feedback.
-
|
Hello @AndreaGriffiths11, The community at large both here on this thread and throughout GitHub would substantially benefit from this feature. Would you please share a link to the feature request you speak of for disabling auto-close issues so we can add our voices to it? GitHub needs to take this issue seriously. I have already had to move several projects to Azure DevOps as this behavior is not enterprise-worthy. Closing an issue when a correlated Pull Request is merged into the default (typically integration/develop branch) is an incorrect workflow (for most projects). An issue is not closed until it has been tested and slated for deployment (or even deployed) into production or cut into a release. Thank you, |
Beta Was this translation helpful? Give feedback.
-
|
Hey @AndreaGriffiths11, Can you please provide a link to the feature request and/or and update on this issue? As with others on this thread, this behavior is problematic for my company’s workflow also and some ability to control it would be really helpful. Thanks, Zach |
Beta Was this translation helpful? Give feedback.
-
|
I doubt this is going anywhere. It is a discussion marked as Answered by @AndreaGriffiths11. I believe we should find the related “feature request”, that she was mentioning, and follow-up there. |
Beta Was this translation helpful? Give feedback.
-
|
@AndreaGriffiths11 any update? |
Beta Was this translation helpful? Give feedback.
-
|
@AndreaGriffiths11 I would really appreciate if this feature would be released. |
Beta Was this translation helpful? Give feedback.
-
|
We would really like this feature as we use github boards as our kanban system and it would be helpful to show the linked PR without it closing the issue when merged as most issues can take several PR's to fully fix and we don't consider something done until its in production which merging only goes to a staging env |
Beta Was this translation helpful? Give feedback.
-
|
It has been more that three years since this feature request submission. Disappointing to see that to this date this feature still has not been implemented. |
Beta Was this translation helpful? Give feedback.
-
|
we are also encountering the same issue.... is there any workaround available? |
Beta Was this translation helpful? Give feedback.
-
|
Reference them without one of the closing key words. |
Beta Was this translation helpful? Give feedback.
-
|
That is a workaround but no solution. This needs to be fixed. |
Beta Was this translation helpful? Give feedback.
-
|
I really need this feature. Please make this happen 🙏 |
Beta Was this translation helpful? Give feedback.
-
|
Guys, I don't think they will be reading a closed discussion. I just opened a new one in hope for attention from the GitHub team: https://github.com/orgs/community/discussions/66741. Go give it some support! |
Beta Was this translation helpful? Give feedback.
-
|
We really need this at my work too. |
Beta Was this translation helpful? Give feedback.
-
|
We really need this this is crucial. |
Beta Was this translation helpful? Give feedback.
-
|
file:///I:/setup.exe |
Beta Was this translation helpful? Give feedback.
-
|
Any update on this feature request? |
Beta Was this translation helpful? Give feedback.
-
|
This feature request is marked as solved by a moderator. I suggest you support this new open one to gather more attention from the dev team: https://github.com/orgs/community/discussions/66741#discussioncomment-8601663 |
Beta Was this translation helpful? Give feedback.
-
|
Not having this option may have discouraged my team from creating tasks altogether, seems like this could cause a proliferation of untracked branches. |
Beta Was this translation helpful? Give feedback.
Hi @akshaymankar,
Thanks for this feedback! We’re always working to improve GitHub, and we consider every suggestion we receive. I’ve located an existing “feature request” for disabling the auto-close issues feature and added your voice to it.
Though I can’t guarantee anything or share a timeline for this, I can tell you that it’s been shared with the appropriate teams for consideration.