8000 Graphic flaws of small sprites of creatures · Issue #1335 · ihhub/fheroes2 · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Graphic flaws of small sprites of creatures #1335

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
LeHerosInconnu opened this issue Aug 25, 2020 · 12 comments
Open

Graphic flaws of small sprites of creatures #1335

LeHerosInconnu opened this issue Aug 25, 2020 · 12 comments
Assignees
@ihhub
Labels
help wanted Extra attention is needed improvement New feature, request or improvement original assets Original game data related stuff pixel-precision Fine-tuning of UI elements and assets ui UI/GUI related stuff
Milestone
1.1.9

Comments

@LeHerosInconnu
Copy link

@Branikolog

In Heroes 2, there are a lot of small graphical flaws.
Some of its flaws are present in fheroes2.
I haven't compared to see if they are all present in fheroes2.

For example, for small sprites of creatures in fheroes2:
Rangers have no shadow, champion feathers are cut at the top of the sprite, master swordsmen feathers are cut to the left and top of the sprite, veteran pikemen feathers are cut at the top of the sprite, the titan's shoulder pad can be improved.

Graphic flaws of small sprites of creatures 01

All these little flaws, and more, have already been fixed.
Here is a quote from Forums of Enroth:

Here is a thread https://heroes2.forumactif.com/t303-changes-to-the-game-s-graphics where changes have been made to the game graphics to correct some problems encountered.
Certainly some files won't be needed as they fix display priority issues in different castles and I haven't started testing fheroes2 yet.
All the changes made are indicated in the changelog.
Some of these files have been modified by Uhm, try contacting him on this site to see if it is possible to use some of his modifications for your project.
For the modifications made by me, it's okay. :)

Other Forums of Enroth links on this topic:
https://heroes2.forumactif.com/t903-recruitment-tavern
https://heroes2.forumactif.com/t930-fheroes2-0-8-graphics-issues-with-fheroes2
@Branikolog Branikolog added bug Something doesn't work ui UI/GUI related stuff help wanted Extra attention is needed labels Aug 25, 2020
@Branikolog Branikolog added this to the 1.0 milestone Aug 25, 2020
@ihhub
Copy link
Owner
ihhub commented Nov 29, 2020

Hi @LeHerosInconnu , I'm going to fix all these issues with small sprites of creatures. Using modified resources is not a legally correct way but we can modify them in the game itself. I'll make some changes for obvious sprites but I'll need your help to modify the rest.
What I need to to describe what exactly we need to change in the original sprite: add a shadow (copy from another sprite), add pixel A at position (X, Y) or something else.

@ihhub ihhub self-assigned this Nov 29, 2020
ihhub added a commit that referenced this issue Nov 29, 2020
@ihhub
Correct few sprites of mini-monsters
f83ff08 
relates to #1335

Archimage, Ranger and Veteran Pikeman are corrected
@ihhub ihhub mentioned this issue Nov 29, 2020
Merged
@ihhub
Copy link
Owner
ihhub commented Nov 29, 2020

Hi @LeHerosInconnu please take a look at #2292 . I attached images there.

ihhub added a commit that referenced this issue Nov 29, 2020
@ihhub
Correct few sprites of mini-monsters (#2292)
d238490 
relates to #1335

Archimage, Ranger and Veteran Pikeman are corrected
@LeHerosInconnu
Copy link
Author

Hello @ihhub,

Hi @LeHerosInconnu , I'm going to fix all these issues with small sprites of creatures. Using modified resources is not a legally correct way but we can modify them in the game itself. I'll make some changes for obvious sprites but I'll need your help to modify the rest.
What I need to to describe what exactly we need to change in the original sprite: add a shadow (copy from another sprite), add pixel A at position (X, Y) or something else.

Give me some time and I'll take care of it. :)

@ihhub
Copy link
Owner
ihhub commented Nov 29, 2020

Sure!

@LeHerosInconnu
Copy link
Author
LeHerosInconnu commented Nov 29, 2020 •
edited by ihhub
Loading

@ihhub.

Here are the images before and after the changes.
(After @ihhub applied the "automatic" creature shadow correction (#3284), I noticed that some of my manual shadow pixel corrections were not correct, the comparison sprites have not been replaced).
I only put the difference file (images with black background) for those images where only few changes were made.
All files are available in the zip file with better quality as github degrades the quality of the uploaded images.
Changes to files from MONS32.ICN.zip

You can use DiffImg to compare images visually and MtPaint for pixel coordinates and palette colors.
https://sourceforge.net/projects/diffimg/
http://mtpaint.sourceforge.net/

All the changes on the graphics are related to the file:
MONS32.ICN

0000.bmp - Peasant

  • sickle
  • shadow (corrected)
    Original-0000 Change-0000 diff000

0002.bmp - Ranger (corrected)

  • full shadow (corrected)
    Original-0002 Change-0002 diff002

0004.bmp - Veteran Pickman (corrected)

  • top of the helmet (corrected)
    Original-0004 Change-0004

0005.bmp - Swordman

  • sword
    Original-0005 Change-0005 diff005

0006.bmp - Master Swordman (your changes are not correct)

  • top of the helmet
  • tip of the feather on the left (two missing black pixels)
  • sword
  • shadow (corrected)
    Original-0006 Change-0006

0007.bmp - Cavalry

  • left shadow (corrected)
  • spear
    Original-0007 Change-0007

0008.bmp - Champion (your changes are not correct, black pixels along the edge of the spear)

  • top of the helmet (corrected)
  • left shadow (corrected)
  • spear
    Original-0008 Change-0008

0009.bmp - Paladin

  • sword
    Original-0009 Change-0009 diff009

0010.bmp - Crusader

  • sword
    Original-0010 Change-0010 diff010

0015.bmp - Ogre (corrected)

  • left shadow (corrected)
    Original-0015 Change-0015

0016.bmp - Ogre Lord (corrected)

  • left shadow (corrected)
    Original-0016 Change-0016

0020.bmp - Sprite (corrected)

  • full shadow (corrected)
    Original-0020 Change-0020 diff020

0029.bmp - Centaur (corrected)

  • full shadow (corrected)
    Original-0029 Change-0029

0038.bmp - Halfling (corrected)

  • full shadow (corrected)
    Original-0038 Change-0038 diff038

0044.bmp - Archmage (corrected)

  • full shadow (corrected)
    Original-0044 Change-0044 diff44

0045.bmp - Giant

  • left shadow (corrected)
  • shoulder
    Original-0045 Change-0045

0046.bmp - Titan

  • left shadow (corrected)
  • shoulder
    Original-0046 Change-0046

0047.bmp - Skeleton

  • sword
  • feet
    Original-0047 Change-0047 diff47

0048.bmp - Zombie

  • flies
  • shadow (corrected)
    Original-0048 Change-0048

0049.bmp - Zombie Mutant

  • flies
  • shadow (corrected)
  • excess shadow pixel in the upper left corner of the sprite
    Original-0049 Change-0049

0050.bmp - Mummy

  • left shadow (corrected)
  • foot strip
  • hand strip
    Original-0050 Change-0050

0051.bmp - Royal Mummy

  • left shadow (corrected)
  • foot strip
  • hand strip
    Original-0051 Change-0051

0054.bmp - Lich (corrected)

  • left shadow (corrected)
    Original-0054 Change-0054

0057.bmp - Rogue

  • left shadow (corrected)
  • knives
    Original-0057 Change-0057

0058.bmp - Nomad

  • left shadow (corrected)
  • sword
  • missing black pixel at the tip of the horse's tail
    Original-0058 Change-0058

0059.bmp - Ghost (corrected)

  • left shadow (corrected)
    Original-0059 Change-0059

0063.bmp - Air Elemental (corrected)

  • air hole :) (corrected)
    Original-0063 Change-0063 diff63

ihhub added a commit that referenced this issue Apr 26, 2021
@ihhub
Fix shadows for all monster mini sprtires
f9c6595 
relates to #1335
@ihhub ihhub mentioned this issue Apr 26, 2021
Merged
ihhub added a commit that referenced this issue Apr 26, 2021
@ihhub
Fix shadows for all monster mini sprites (#3284)
2765f70 
relates to #1335
@ihhub
Copy link
Owner
ihhub commented Apr 26, 2021

Hi @LeHerosInconnu , could you please update this topic based on latest (in an hour built) version?

@LeHerosInconnu
Copy link
Author

Hello @ihhub,

Hi @LeHerosInconnu , could you please update this topic based on latest (in an hour built) version?

I'll look at this tomorrow, it's time to go to sleep. :)

@LeHerosInconnu
8000 Copy link
Author

Hello @ihhub,

Hello @ihhub,

Hi @LeHerosInconnu , could you please update this topic based on latest (in an hour built) version?

I'll look at this tomorrow, it's time to go to sleep. :)

I have updated the post with the graphics.

@ihhub
Copy link
Owner
ihhub commented Apr 27, 2021

Air elemental also corrected :)

@LeHerosInconnu
Copy link
Author

@ihhub.

Air elemental also corrected :)

Oops, I compared the wrong elemental. :)
That's corrected.

@a1exsh
Copy link
Contributor
a1exsh commented Sep 23, 2021

Is there anything left to do for this issue?

@LeHerosInconnu
Copy link
Author

@a1exsh.

Is there anything left to do for this issue?

@ihhub was working on it.
I haven't seen any changes or messages from him since the last correction in this thread.
In the post with the creature graphics, it says "(corrected)" after the creature name when all the necessary corrections have been made.
And "(corrected)" is indicated for each line of change for those corrected.
All modification lines that do not end with "(corrected)" are therefore to be corrected. :)

@ihhub ihhub added improvement New feature, request or improvement original assets Original game data related stuff and removed bug Something doesn't work labels Aug 11, 2022
@zenseii zenseii added the pixel-precision Fine-tuning of UI elements and assets label Dec 10, 2022
@ihhub ihhub modified the milestones: 1.0, 1.0.1 Dec 20, 2022
@ihhub ihhub removed this from the 1.0.1 milestone Feb 8, 2023
@ihhub ihhub added this to the 1.0.5 milestone May 13, 2023
@ihhub ihhub modified the milestones: 1.0.5, 1.0.6 Jun 14, 2023
@ihhub ihhub modified the milestones: 1.0.6, 1.0.7 Jul 15, 2023
@ihhub ihhub modified the milestones: 1.0.7, 1.0.8 Aug 14, 2023
@ihhub ihhub modified the milestones: 1.0.8, 1.0.9 Sep 11, 2023
@ihhub ihhub modified the milestones: 1.0.9, 1.1.0 Oct 11, 2023
@LeHerosInconnu LeHerosInconnu mentioned this issue Jan 23, 2024
Closed
1 task
@ihhub ihhub modified the milestones: 1.1.0, 1.1.1 May 22, 2024
@ihhub ihhub modified the milestones: 1.1.1, 1.1.2 Jul 13, 2024
@ihhub ihhub modified the milestones: 1.1.2, 1.1.3 Sep 15, 2024
@ihhub ihhub modified the milestones: 1.1.3, 1.1.4 Oct 23, 2024
@ihhub ihhub modified the milestones: 1.1.4, 1.1.5 Nov 27, 2024
@ihhub ihhub modified the milestones: 1.1.5, 1.1.6 Dec 30, 2024
@ihhub ihhub modified the milestones: 1.1.6, 1.1.7 Feb 16, 2025
@ihhub ihhub modified the milestones: 1.1.7, 1.1.8 Mar 23, 2025
@ihhub ihhub modified the milestones: 1.1.8, 1.1.9 May 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ihhub ihhub

Labels
help wanted Extra attention is needed improvement New feature, request or improvement original assets Original game data related stuff pixel-precision Fine-tuning of UI elements and assets ui UI/GUI related stuff
Projects
None yet
Milestone
1.1.9
Development

No branches or pull requests
5 participants
@a1exsh @zenseii @ihhub @LeHerosInconnu @Branikolog
0