Generic sdl2 game controller support on compatible devices #4435
Labels
Milestone
Comments
|
Hi @romadu , we went through this discussion in the past and as far as I know the problem is that some systems recognize extra controllers making difficult to play the game. Are you on Linux? |
|
Yes this is on Linux. Anyway, I managed to compile and have game controller
support by removing the #ifdef check (because I know my system has only one
controller). I was just wondering if there was a way to create a generic
fix for others in my situation in the future.
…On Sat, 16 Oct 2021 at 23:54, Ihar Hubchyk ***@***.***> wrote:
Hi @romadu <https://github.com/romadu> , we went through this discussion
in the past and as far as I know the problem is that some systems recognize
extra controllers making difficult to play the game. Are you on Linux?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#4435 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AD27XCZY7YZGRDYFRQ7NRTDUHGN43ANCNFSM5GDCBVEQ>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_c
10000
ampaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
|
|
Some discussion about controllers are made in #2455. |
ihhub
added a commit
that referenced
this issue
Jul 2, 2023
close #4435 We were facing issues with controllers when software cursor mode was not set. In the past we were toggling between hardware and software cursor modes. However, now if software cursor mode is set we never set if off. In this case it is safe to enable controller support for such cases.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Preliminary checks
Describe the problem requiring a solution
This #ifdef restriction means that sdl2 game controller is only initialised on Vita or Switch, and not on other systems with compatible sdl2 game controllers. Perhaps game controller support can be made more generic.
fheroes2/src/fheroes2/game/fheroes2.cpp
Line 150 in c79c986
Describe the possible solution
By removing this #ifdef I am able to initialise game controller support on linux handheld devices. However, I'm not sure if that's the best solution for all use cases.
Additional info
fheroes2/src/fheroes2/game/fheroes2.cpp
Line 150 in c79c986
The text was updated successfully, but these errors were encountered: