Avoid using an offset framebuffer for overlarge texturing #7289
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When texturing from the entire 512 height of a framebuffer, we still should not trigger the offset framebuffer code. This is expected to help Danball Senki BOOST but not break Breath of Fire 3.
hrydgard
added a commit
that referenced
this pull request
Jan 7, 2015
Avoid using an offset framebuffer for overlarge texturing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When texturing from the entire 512 height of a framebuffer, we still should not trigger the offset framebuffer code.
This helps Danball Senki BOOST (#5918) without breaking Breath of Fire 3. Also fixes #7011 (Prince of Persia: The Forgotten Sands.) I guess in both cases they're stretching the vertex positions and just relying on clipping, rather than texturing from the correct area.
-[Unknown]