8000 Add changes from comments after merging AccuWeather PR by bieniu · Pull Request #38227 · home-assistant/core · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Add changes from comments after merging AccuWeather PR #38227

8000
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jul 27, 2020
Merged

Add changes from comments after merging AccuWeather PR #38227

merged 5 commits into from
Jul 27, 2020

Conversation

bieniu
Copy link
Member
@bieniu bieniu commented Jul 26, 2020 •
edited
Loading

Breaking change

None

Proposed change

This PR adds changes from comments after merging #37166

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example entry for configuration.yaml:

# Example configuration.yaml

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

ctalkington
ctalkington approved these changes Jul 27, 2020
View reviewed changes
Copy link
Contributor
@ctalkington ctalkington left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice! thanks for resolving those comments.

@ctalkington ctalkington merged commit 2b09149 into home-assistant:dev Jul 27, 2020
@bieniu bieniu deleted the accuweather-fix branch July 27, 2020 04:06
hahn-th pushed a commit to hahn-th/core that referenced this pull request May 2, 2025
@dependabot
build(deps-dev): bump rubocop from 1.74.0 to 1.75.1 (home-assistant#3…
efd7835 
…8227)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ctalkington ctalkington ctalkington approved these changes

Assignees
No one assigned
Labels
by-code-owner cla-signed code-quality has-tests integration: accuweather small-pr PRs with less than 30 lines.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ctalkington @homeassistant
0