8000 Add AccuWeather integration by bieniu · Pull Request #37166 · home-assistant/core · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Add AccuWeather integration #37166

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 18 commits into from
Jul 24, 2020
Merged

Add AccuWeather integration #37166

merged 18 commits into from
Jul 24, 2020

Conversation

bieniu
Copy link
Member
@bieniu bieniu commented Jun 27, 2020

Breaking change

Proposed change

This PR adds new weather integration that shows data from AccuWeather. The integration uses only config flow configuration.

AccuWeather's terms of use allow for one free API key per user and 50 requests per day. So integration only allows to configure one instance and downloading the weather forecast is optional (config flow options). Downloading the forecast increases the number of requests. With a forecast, the data is updated every 64 minutes, without a forecast, every 32 minutes.

This is the initial PR, I plan to add the sensor platform in the future PR.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example entry for configuration.yaml:

# Example configuration.yaml

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

@bieniu bieniu closed this Jun 27, 2020
@bieniu bieniu reopened this Jun 27, 2020
@bieniu bieniu changed the title Accuweather Add Accuweather integration Jun 27, 2020
@bieniu bieniu changed the title Add Accuweather integration Add AccuWeather integration Jun 27, 2020
@heytcass
Copy link
Contributor
heytcass commented Jul 7, 2020

+1 for this. Seems like a great alternative to Dark Sky. Was actually looking into getting it going myself, which is why I searched here. But I am not a developer by any means, so it would have taken me a long time. Glad to see someone else had the same idea. May take a stab at helping with documentation if I get some free time.

Copy link
Contributor
@ctalkington ctalkington left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just an initial pass to get review process started.


undo_listener = config_entry.add_update_listener(update_listener)

hass.data.setdefault(DOMAIN, {})
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
hass.data.setdefault(DOMAIN, {})

},
"error": {
"cannot_connect": "[%key:common::config_flow::error::cannot_connect%]",
"invalid_api_key": "Your API Key is invalid.",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"invalid_api_key": "Your API Key is invalid.",
"invalid_api_key": "[%key:common::config_flow::error::invalid_auth%]",

Copy link
Contributor
@ctalkington ctalkington left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this seems ok to me. you may see some usually minor requests for tweaks come in as others get free time to review so just be on the lookout for such.

This has plenty of time to be tested before any real release.

@ctalkington ctalkington merged commit 581c4a4 into home-assistant:dev Jul 24, 2020
@bieniu bieniu deleted the accuweather branch July 24, 2020 21:15
Copy link
Member
@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Please address the comments in a follow up PR. Thanks!

hahn-th pushed a commit to hahn-th/core that referenced this pull request May 2, 2025
* Add note about LG webOS TV icon file location

* tiny tweak

---------

Co-authored-by: c0ffeeca7 <38767475+c0ffeeca7@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants
0