-
-
Notifications
You must be signed in to change notification settings - Fork 33.7k
Add AccuWeather integration #37166
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add AccuWeather integration #37166
Conversation
+1 for this. Seems like a great alternative to Dark Sky. Was actually looking into getting it going myself, which is why I searched here. But I am not a developer by any means, so it would have taken me a long time. Glad to see someone else had the same idea. May take a stab at helping with documentation if I get some free time. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just an initial pass to get review process started.
|
||
undo_listener = config_entry.add_update_listener(update_listener) | ||
|
||
hass.data.setdefault(DOMAIN, {}) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hass.data.setdefault(DOMAIN, {}) |
}, | ||
"error": { | ||
"cannot_connect": "[%key:common::config_flow::error::cannot_connect%]", | ||
"invalid_api_key": "Your API Key is invalid.", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"invalid_api_key": "Your API Key is invalid.", | |
"invalid_api_key": "[%key:common::config_flow::error::invalid_auth%]", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this seems ok to me. you may see some usually minor requests for tweaks come in as others get free time to review so just be on the lookout for such.
This has plenty of time to be tested before any real release.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! Please address the comments in a follow up PR. Thanks!
* Add note about LG webOS TV icon file location * tiny tweak --------- Co-authored-by: c0ffeeca7 <38767475+c0ffeeca7@users.noreply.github.com>
Breaking change
Proposed change
This PR adds new weather integration that shows data from AccuWeather. The integration uses only
config flow
configuration.AccuWeather's terms of use allow for one free API key per user and 50 requests per day. So integration only allows to configure one instance and downloading the weather forecast is optional (config flow options). Downloading the forecast increases the number of requests. With a forecast, the data is updated every 64 minutes, without a forecast, every 32 minutes.
This is the initial PR, I plan to add the
sensor
platform in the future PR.Type of change
Example entry for
configuration.yaml
:# Example configuration.yaml
Additional information
Checklist
black --fast homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.The integration reached or maintains the following Integration Quality Scale: