8000 Update async-upnp-client library to 0.23.1 by chishm · Pull Request #62298 · home-assistant/core · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Update async-upnp-client library to 0.23.1 #62298

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 19, 2021
Merged

Update async-upnp-client library to 0.23.1 #62298

merged 1 commit into from
Dec 19, 2021

Conversation

chishm
Copy link
Contributor
@chishm chishm commented Dec 19, 2021

Proposed change

Update async-upnp-client library to 0.23.1.

Changelog: https://github.com/StevenLooman/async_upnp_client/blob/0.23.1/CHANGES.rst

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

@chishm chishm requested a review from StevenLooman as a code owner December 19, 2021 04:47
@probot-home-assistant
Copy link

Hey there @StevenLooman, @ehendrix23, mind taking a look at this pull request as it has been labeled with an integration (upnp) you are listed as a code owner for? Thanks!
(message by CodeOwnersMention)

@probot-home-assistant
Copy link

Hey there @StevenLooman, mind taking a look at this pull request as it has been labeled with an integration (dlna_dmr) you are listed as a code owner for? Thanks!
(message by CodeOwnersMention)

@probot-home-assistant
Copy link

Hey there @zewelor, @shenxn, @starkillerOG, mind taking a look at this pull request as it has been labeled with an integration (yeelight) you are listed as a code owner for? Thanks!
(message by CodeOwnersMention)

bdraco
bdraco approved these changes Dec 19, 2021
View reviewed changes
Copy link
Member
@bdraco bdraco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and working 👍

@bdraco bdraco merged commit f280b03 into home-assistant:dev Dec 19, 2021
@chishm chishm deleted the bump-async-upnp-client branch December 19, 2021 11:39
@frenck
Copy link
Member
frenck commented Dec 19, 2021

Should this go into the .4 patch release?

@chishm
Copy link
Contributor Author
chishm commented Dec 19, 2021

Yes, provided the bump to 0.23.0 was already cherry-picked into the .4 patch release. There was a test failure caused by the update from 0.22.12 to 0.23.0 that needed to be addressed, and this test failure would've occurred for 0.23.1 had it not already been addressed.

@frenck frenck added this to the 2021.12.4 milestone Dec 19, 2021
balloob pushed a commit that referenced this pull request Dec 20, 2021
@chishm @balloob
Update async-upnp-client library to 0.23.1 (#62298)
b327628
@balloob balloob mentioned this pull request Dec 20, 2021
Merged
@github-actions github-actions bot locked and limited conversation to collaborators Dec 21, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bdraco bdraco bdraco approved these changes

@StevenLooman StevenLooman Awaiting requested review from StevenLooman StevenLooman is a code owner

Assignees

@StevenLooman StevenLooman

Labels
bugfix by-code-owner cherry-picked cla-signed core dependency dependency-bump integration: dlna_dmr integration: ssdp integration: upnp integration: yeelight small-pr PRs with less than 30 lines.
Projects
None yet
Milestone
2021.12.4
Development

Successfully merging this pull request may close these issues.

Missing StateVariable AVT/CurrentTrackURI
6 participants
@chishm @frenck @bdraco @StevenLooman @balloob @homeassistant
0