8000 Bump async-upnp-client to 0.23.0 by Flameeyes · Pull Request #62223 · home-assistant/core · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Bump async-upnp-client to 0.23.0 #62223

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 17, 2021
Merged

Bump async-upnp-client to 0.23.0 #62223

merged 1 commit into from
Dec 17, 2021

Conversation

Flameeyes
Copy link
Contributor
@Flameeyes Flameeyes commented Dec 17, 2021 •
edited
Loading

Proposed change

Update async-upnp-client library to 0.23.0.

Changelog: https://github.com/StevenLooman/async_upnp_client/blob/0.23.0/CHANGES.rst

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • [] Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

@probot-home-assistant
Copy link

Hey there @rytilahti, @zewelor, @shenxn, @starkillerOG, mind taking a look at this pull request as it has been labeled with an integration (yeelight) you are listed as a code owner for? Thanks!
(message by CodeOwnersMention)

@probot-home-assistant
Copy link

Hey there @StevenLooman, @ehendrix23, mind taking a look at this pull request as it has been labeled with an integration (upnp) you are listed as a code owner for? Thanks!
(message by CodeOwnersMention)

@probot-home-assistant
Copy link

Hey there @StevenLooman, @chishm, mind taking a look at this pull request as it has been labeled with an integration (dlna_dmr) you are listed as a code owner for? Thanks!
(message by CodeOwnersMention)

@MartinHjelmare MartinHjelmare changed the title Update async-upnp-client version. Bump async-upnp-client to 0.23.0 Dec 17, 2021
@MartinHjelmare
Copy link
Member

Please add a link to a changelog or GitHub commit compare view for the version bump in the PR description. Thanks!

bdraco
bdraco requested changes Dec 17, 2021
View reviewed changes
Copy link
Member
@bdraco bdraco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a legitimate test failure here that needs to be addressed. Thanks

@Flameeyes
Copy link
Contributor Author

TIL tox doesn't update deps when the requirements_test_all.txt file changes. No kidding the tests didn't fail locally. 😓

Re-running tests with a clean environment this time.

@Flameeyes Flameeyes requested a review from bdraco December 17, 2021 20:53
bdraco
bdraco approved these changes Dec 17, 2021
View reviewed changes
Copy link
Member
@bdraco bdraco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did some testing with discovery to make sure everything still works.

Thanks @Flameeyes 👍

@bdraco bdraco merged commit 6ce99bf into home-assistant:dev Dec 17, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Dec 18, 2021
@balloob balloob added this to the 2021.12.4 milestone Dec 20, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bdraco bdraco bdraco approved these changes

@rytilahti rytilahti Awaiting requested review from rytilahti

@StevenLooman StevenLooman Awaiting requested review from StevenLooman StevenLooman is a code owner

Assignees

@StevenLooman StevenLooman

@rytilahti rytilahti

Labels
cherry-picked cla-signed core dependency dependency-bump integration: dlna_dmr integration: ssdp integration: upnp integration: yeelight small-pr PRs with less than 30 lines.
Projects
None yet
Milestone
2021.12.4
Development

Successfully merging this pull request may close these issues.
7 participants
@Flameeyes @MartinHjelmare @bdraco @StevenLooman @balloob @rytilahti @homeassistant
0