8000 Fix Nut resources option migration by ollo69 · Pull Request #59020 · home-assistant/core · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Fix Nut resources option migration #59020

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 4, 2021
Merged

Fix Nut resources option migration #59020

merged 2 commits into from
Nov 4, 2021

Conversation

ollo69
Copy link
Contributor
@ollo69 ollo69 commented Nov 3, 2021

Proposed change

There is a little issue in migration of entity status enabled based on entry configuration resources. When resources is also configured as entry options, this value should be used to replace the current value in the entry data.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

@ollo69 ollo69 requested a review from bdraco as a code owner November 3, 2021 23:34
@probot-home-assistant probot-home-assistant bot added bugfix integration: nut small-pr PRs with less than 30 lines. labels Nov 3, 2021
@probot-home-assistant
Copy link

Hey there @bdraco, mind taking a look at this pull request as it has been labeled with an integration (nut) you are listed as a code owner for? Thanks!
(message by CodeOwnersMention)

MartinHjelmare
MartinHjelmare requested changes Nov 4, 2021
View reviewed changes
Copy link
Member
@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the future, I suggest we remove the resources selection from the config flow completely and just set a default selection from the beginning.

@ollo69 @MartinHjelmare
Apply suggestions from code review
096353c 
Co-authored-by: Martin Hjelmare <marhje52@gmail.com>
@ollo69
Copy link
Contributor Author
ollo69 commented Nov 4, 2021

For the future, I suggest we remove the resources selection from the config flow completely and just set a default selection from the beginning.

Totally agree, i was just waiting for closure of PR #58798 to have a better idea of what consider main resources to enable by default.

MartinHjelmare
MartinHjelmare approved these changes Nov 4, 2021
View reviewed changes
Copy link
Member
@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@MartinHjelmare
Copy link
Member

Is this fixing something we released yesterday in 2021.11.0?

@ollo69
Copy link
Contributor Author
ollo69 commented Nov 4, 2021

Without this PR moving from 2021.10.x to 2021.11.x may cause having all Nut entities enabled. Unfortunately will not fix for who already migrate to 2021.11.0.

@MartinHjelmare MartinHjelmare added this to the 2021.11.1 milestone Nov 4, 2021
@MartinHjelmare MartinHjelmare merged commit ea6504d into home-assistant:dev Nov 4, 2021
@ollo69 ollo69 deleted the nut-migr-issue branch November 4, 2021 13:36
balloob pushed a commit that referenced this pull request Nov 5, 2021
@ollo69 @MartinHjelmare @balloob
Fix Nut resources option migration (#59020)
b125e2c 
Co-authored-by: Martin Hjelmare <marhje52@gmail.com>
@balloob balloob mentioned this pull request Nov 5, 2021
Merged
@github-actions github-actions bot locked and limited conversation to collaborators Nov 6, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@MartinHjelmare MartinHjelmare MartinHjelmare approved these changes

@bdraco bdraco Awaiting requested review from bdraco bdraco is a code owner

Assignees

@bdraco bdraco

Labels
bugfix by-code-owner cherry-picked cla-signed integration: nut small-pr PRs with less than 30 lines.
Projects
None yet
Milestone
2021.11.1
Development

Successfully merging this pull request may close these issues.
5 participants
@ollo69 @MartinHjelmare @bdraco @balloob @homeassistant
0