Add entity categories to most NUT entities #58798
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey there @bdraco, @ollo69, mind taking a look at this pull request as it has been labeled with an integration ( |
garbled1
reviewed
Nov 1, 2021
ollo69
reviewed
Nov 2, 2021
22 tasks
|
Ok made changes. I also left an Alarm sensor and a battery status sensor that could be useful if exposed by someone's UPS. And if we are leaving output/input voltages in, a watts sensor should be left too (probably won't be available for most UPS anyway but if it is it's something they can use for energy) |
ollo69
approved these changes
Nov 4, 2021
|
LGTM |
bdraco
approved these changes
Nov 4, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Breaking change
Proposed change
Adding entity categories to most NUT entities as only very few were updated initially.
I'd argue battery charge should not be diagnostic but I'm sure no one will agree 😆
Type of change
Additional information
Checklist
black --fast homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.The integration reached or maintains the following Integration Quality Scale:
To help with the load of incoming pull requests: