8000 Fresh attempt at SimpliSafe auto-relogin by bachya · Pull Request #52567 · home-assistant/core · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Fresh attempt at SimpliSafe auto-relogin #52567

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 6, 2021
Merged

Fresh attempt at SimpliSafe auto-relogin #52567

merged 2 commits into from
Jul 6, 2021

Conversation

bachya
Copy link
Contributor
@bachya bachya commented Jul 6, 2021 •
edited
Loading

Proposed change

Following up on #52484, I was able to come up with a more solid way to ensure that SimpliSafe automatically reauthenticates after its refresh token expires (this all happens under the hood in simplisafe-python). Note that the bulk of this PR merely recreates the already-approved #51528; the remainder has to do with bumping simplisafe-python.

Changelog: https://github.com/bachya/simplisafe-python/releases/tag/11.0.0
Diff: bachya/simplisafe-python@10.0.0...11.0.0

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

@bachya bachya added this to the 2021.7.0 milestone Jul 6, 2021
@bachya bachya self-assigned this Jul 6, 2021
@bachya bachya removed this from the 2021.7.0 milestone Jul 6, 2021
@bachya bachya added this to the 2021.7.0 milestone Jul 6, 2021
@bachya bachya marked this pull request as ready for review July 6, 2021 14:21
frenck
frenck approved these changes Jul 6, 2021
View reviewed changes
Copy link
Member
@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ✅

@frenck frenck merged commit 40ad25d into home-assistant:dev Jul 6, 2021
frenck pushed a commit that referenced this pull request Jul 6, 2021
@bachya @frenck
Fresh attempt at SimpliSafe auto-relogin (#52567)
746a52b 
* Fresh attempt at SimpliSafe auto-relogin

* Fix tests
@github-actions github-actions bot locked and limited conversation to collaborators Jul 7, 2021
@bachya bachya deleted the ss-reaut branch July 22, 2021 17:12
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@frenck frenck frenck approved these changes

Assignees

@bachya bachya

Labels
by-code-owner cherry-picked cla-signed dependency has-tests integration: simplisafe small-pr PRs with less than 30 lines.
Projects
None yet
Milestone
2021.7.0
Development

Successfully merging this pull request may close these issues.

2021.7.0bx: SimpliSafe showing authentication error
3 participants
@bachya @frenck @homeassistant
0