8000 Revert "Force SimpliSafe to reauthenticate with a password (#51528)" by bachya · Pull Request #52484 · home-assistant/core · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Revert "Force SimpliSafe to reauthenticate 8000 with a password (#51528)" #52484

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 5, 2021
Merged

Revert "Force SimpliSafe to reauthenticate with a password (#51528)" #52484

merged 1 commit into from
Jul 5, 2021

Conversation

bachya
Copy link
Contributor
@bachya bachya commented Jul 3, 2021

This reverts commit 549f779.

Proposed change

#51528 attempted to implement logic whereby SimpliSafe could reauthenticate with username and password. Unfortunately, the architecture of simplisafe-python doesn't quite allow for this simplistic of an approach and I have not yet been able to discover a proper workaround. So, to not hinder the remainder of the 2021.7.0 beta or general release, this PR reverts that commit until I can create a more holistic fix.

Since this was all slated for 2021.7.0, it is not a breaking change.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

@bachya bachya self-assigned this Jul 3, 2021
@bachya bachya added this to the 2021.7.0 milestone Jul 3, 2021
@frenck frenck merged commit 64e63de into home-assistant:dev Jul 5, 2021
frenck pushed a commit that referenced this pull request Jul 5, 2021
@bachya @frenck
Revert "Force SimpliSafe to reauthenticate with a password (#51528)" (#…
afb1879 
…52484)

This reverts commit 549f779.
@bachya bachya deleted the ss-revert branch July 6, 2021 02:48
@bachya bachya mentioned this pull request Jul 6, 2021
Merged
21 tasks
@github-actions github-actions bot locked and limited conversation to collaborators Jul 7, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@frenck frenck frenck approved these changes

Assignees

@bachya bachya

Labels
bugfix by-code-owner cherry-picked cla-signed has-tests integration: simplisafe
Projects
None yet
Milestone
2021.7.0
Development

Successfully merging this pull request may close these issues.

2021.7.0bx: SimpliSafe showing authentication error
3 participants
@bachya @frenck @homeassistant
0